[Merged by Bors] - chore(*): golf #18111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
|
LGTM I think more of the files have been ported in the meantime, so please update the Lean 4 PR bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 25, 2023
### Sets * Add `set.maps_to_prod_map_diagonal`, `set.diagonal_nonempty`, and `set.diagonal_subset_iff`. ### Filters * Generalize and rename `nhds_eq_comap_uniformity_aux` to `filter.mem_comap_prod_mk`. * Add `set.nonempty.principal_ne_bot` and `filter.comap_id'`. * Rename `filter.has_basis.comp_of_surjective` to `filter.has_basis.comp_surjective`. ### Uniform spaces * Rename `monotone_comp_rel` to `monotone.comp_rel` to enable dot notation. * Add `nhds_eq_comap_uniformity'`. * Use `𝓝ˢ (diagonal γ)` instead of `⨆ x, 𝓝 (x, x)` in `uniform_space_of_compact_t2`. * Golf here and there. ### Mathlib 4 port Relevant parts are forward-ported in leanprover-community/mathlib4#1438
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 25, 2023
This is a partial forward-port of leanprover-community/mathlib#18111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets
set.maps_to_prod_map_diagonal,set.diagonal_nonempty, andset.diagonal_subset_iff.Filters
nhds_eq_comap_uniformity_auxtofilter.mem_comap_prod_mk.set.nonempty.principal_ne_botandfilter.comap_id'.filter.has_basis.comp_of_surjectivetofilter.has_basis.comp_surjective.Uniform spaces
monotone_comp_reltomonotone.comp_relto enable dot notation.nhds_eq_comap_uniformity'.𝓝ˢ (diagonal γ)instead of⨆ x, 𝓝 (x, x)inuniform_space_of_compact_t2.Mathlib 4 port
Relevant parts are forward-ported in leanprover-community/mathlib4#1438