Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Feat: add lemmas about Set.diagonal #1438

Closed
wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 9, 2023

This is a partial forward-port of leanprover-community/mathlib#18111

@urkud urkud added awaiting-review The author would like community review of the PR mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels Jan 11, 2023
@kbuzzard
Copy link
Member

This has not yet been merged in mathlib3. What is the policy here? To wait until the mathlib3 PR is merged?

@fpvandoorn
Copy link
Member

Needs to be updated after new files have been ported

@fpvandoorn fpvandoorn added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 25, 2023
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Jan 25, 2023
### Sets

* Add `set.maps_to_prod_map_diagonal`, `set.diagonal_nonempty`, and `set.diagonal_subset_iff`.

### Filters

* Generalize and rename `nhds_eq_comap_uniformity_aux` to `filter.mem_comap_prod_mk`.
* Add `set.nonempty.principal_ne_bot` and `filter.comap_id'`.
* Rename `filter.has_basis.comp_of_surjective` to `filter.has_basis.comp_surjective`.

### Uniform spaces

* Rename `monotone_comp_rel` to `monotone.comp_rel` to enable dot notation.
* Add `nhds_eq_comap_uniformity'`.
* Use `𝓝ˢ (diagonal γ)` instead of `⨆ x, 𝓝 (x, x)` in `uniform_space_of_compact_t2`.
* Golf here and there.

### Mathlib 4 port

Relevant parts are forward-ported in leanprover-community/mathlib4#1438
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 25, 2023
@fpvandoorn
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Jan 25, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Jan 25, 2023
@urkud
Copy link
Member Author

urkud commented Jan 25, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 25, 2023
bors bot pushed a commit that referenced this pull request Jan 25, 2023
@bors
Copy link

bors bot commented Jan 25, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Feat: add lemmas about Set.diagonal [Merged by Bors] - Feat: add lemmas about Set.diagonal Jan 25, 2023
@bors bors bot closed this Jan 25, 2023
@bors bors bot deleted the YK-set-diag branch January 25, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants