-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Feat: add lemmas about Set.diagonal
#1438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
The author would like community review of the PR
mathlib3-pair
This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged
labels
Jan 11, 2023
This has not yet been merged in mathlib3. What is the policy here? To wait until the mathlib3 PR is merged? |
fpvandoorn
reviewed
Jan 25, 2023
Needs to be updated after new files have been ported |
fpvandoorn
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Jan 25, 2023
bors bot
pushed a commit
to leanprover-community/mathlib
that referenced
this pull request
Jan 25, 2023
### Sets * Add `set.maps_to_prod_map_diagonal`, `set.diagonal_nonempty`, and `set.diagonal_subset_iff`. ### Filters * Generalize and rename `nhds_eq_comap_uniformity_aux` to `filter.mem_comap_prod_mk`. * Add `set.nonempty.principal_ne_bot` and `filter.comap_id'`. * Rename `filter.has_basis.comp_of_surjective` to `filter.has_basis.comp_surjective`. ### Uniform spaces * Rename `monotone_comp_rel` to `monotone.comp_rel` to enable dot notation. * Add `nhds_eq_comap_uniformity'`. * Use `𝓝ˢ (diagonal γ)` instead of `⨆ x, 𝓝 (x, x)` in `uniform_space_of_compact_t2`. * Golf here and there. ### Mathlib 4 port Relevant parts are forward-ported in leanprover-community/mathlib4#1438
urkud
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Jan 25, 2023
bors d+ |
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
The author would like community review of the PR
labels
Jan 25, 2023
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 25, 2023
This is a partial forward-port of leanprover-community/mathlib#18111
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Feat: add lemmas about
[Merged by Bors] - Feat: add lemmas about Jan 25, 2023
Set.diagonal
Set.diagonal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
delegated
mathlib3-pair
This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged
ready-to-merge
This PR has been sent to bors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial forward-port of leanprover-community/mathlib#18111