-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(analysis/calculus/deriv): Use equality of functions #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
reviewed
Dec 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a fair amount of quasi-duplicate statements. I hope this could be hidden/automated at some point in the future.
sgouezel
reviewed
Dec 24, 2019
This way we can rewrite, e.g., in `deriv (deriv sin)`.
Co-Authored-By: Johan Commelin <johan@commelin.net>
sgouezel
added
the
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
label
Dec 27, 2019
sgouezel
approved these changes
Dec 27, 2019
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…ver-community#1818) * refactor(analysis/calculus/deriv): Use equality of functions This way we can rewrite, e.g., in `deriv (deriv sin)`. * Restore some old lemmas * Restore old `deriv_cos`, fix `deriv_id'` * Update src/analysis/calculus/deriv.lean Co-Authored-By: Johan Commelin <johan@commelin.net> * Fix compile Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…ver-community#1818) * refactor(analysis/calculus/deriv): Use equality of functions This way we can rewrite, e.g., in `deriv (deriv sin)`. * Restore some old lemmas * Restore old `deriv_cos`, fix `deriv_id'` * Update src/analysis/calculus/deriv.lean Co-Authored-By: Johan Commelin <johan@commelin.net> * Fix compile Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can rewrite, e.g., in
deriv (deriv sin)
.TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list