Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(analysis/calculus/deriv): Use equality of functions #1818

Merged
merged 7 commits into from
Dec 27, 2019

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 21, 2019

This way we can rewrite, e.g., in deriv (deriv sin).

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@urkud urkud added the WIP Work in progress label Dec 21, 2019
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a fair amount of quasi-duplicate statements. I hope this could be hidden/automated at some point in the future.

src/analysis/calculus/deriv.lean Outdated Show resolved Hide resolved
src/analysis/complex/exponential.lean Outdated Show resolved Hide resolved
@urkud urkud removed the WIP Work in progress label Dec 24, 2019
urkud and others added 2 commits December 25, 2019 04:12
Co-Authored-By: Johan Commelin <johan@commelin.net>
@sgouezel sgouezel added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Dec 27, 2019
@mergify mergify bot merged commit 89854fa into master Dec 27, 2019
@mergify mergify bot deleted the deriv-funext branch December 27, 2019 11:09
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…ver-community#1818)

* refactor(analysis/calculus/deriv): Use equality of functions

This way we can rewrite, e.g., in `deriv (deriv sin)`.

* Restore some old lemmas

* Restore old `deriv_cos`, fix `deriv_id'`

* Update src/analysis/calculus/deriv.lean

Co-Authored-By: Johan Commelin <johan@commelin.net>

* Fix compile

Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
…ver-community#1818)

* refactor(analysis/calculus/deriv): Use equality of functions

This way we can rewrite, e.g., in `deriv (deriv sin)`.

* Restore some old lemmas

* Restore old `deriv_cos`, fix `deriv_id'`

* Update src/analysis/calculus/deriv.lean

Co-Authored-By: Johan Commelin <johan@commelin.net>

* Fix compile

Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants