Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(data/finsupp/basic): split out alist results #18250

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jan 20, 2023

This file is getting quite long, and nothing else builds upon these results.

These lemmas and definitions are copied without modification. They were originally from #15443.


The first commit is from that PR.

Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jan 20, 2023
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 20, 2023
@eric-wieser eric-wieser changed the base branch from master to staging January 20, 2023 21:51
@eric-wieser eric-wieser changed the base branch from staging to master January 20, 2023 21:51
These lemmas and definitions are copied without modification.
@eric-wieser eric-wieser removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 20, 2023
@mathlib-dependent-issues-bot
Copy link
Collaborator

@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jan 21, 2023
@vihdzp
Copy link
Collaborator

vihdzp commented Jan 21, 2023

These results will be built upon once I develop the set_theory/ordinal/cantor_normal_form.lean file further. The idea (as explained in #16010) is to first define the Cantor Normal Form of an ordinal as an association list, and then use these functions to easily talk about the coefficients.

That rant aside, this LGTM.

@eric-wieser
Copy link
Member Author

Oh absolutely, I'm not saying that the results will never be used; just that they're not likely to be used by anything else in finsupp/basic, and since the file is already large, should probably be in a new file.

Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is a useful split. I checked and the only difference introduced is that you haven't opened the finset and function namespaces.

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@sgouezel
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 22, 2023
bors bot pushed a commit that referenced this pull request Jan 22, 2023
This file is getting quite long, and nothing else builds upon these results.

These lemmas and definitions are copied without modification. They were originally from #15443.
@bors
Copy link

bors bot commented Jan 22, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(data/finsupp/basic): split out alist results [Merged by Bors] - refactor(data/finsupp/basic): split out alist results Jan 22, 2023
@bors bors bot closed this Jan 22, 2023
@bors bors bot deleted the eric-wieser/split-alist branch January 22, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants