Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

refactor(set_theory/ordinal/cantor_normal_form): CNF as an association list#16010

Open
vihdzp wants to merge 46 commits intomasterfrom
CNF_alist'
Open

refactor(set_theory/ordinal/cantor_normal_form): CNF as an association list#16010
vihdzp wants to merge 46 commits intomasterfrom
CNF_alist'

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Aug 11, 2022

We define CNF as an association list, and rename the old unbundled definition to CNF_list. We also restate some theorems using the list.keys and list.lookup API.

Association lists are the most natural structure for the CNF, since the CNF has the following properties:

  • it is functional, in that every exponent is assigned at most one coefficient.
  • it is ordered, in decreasing order of exponents.
  • it is finite in length.

Though some proofs had to be reordered (so that I could use mem_lookup_iff), they've remained minimally changed.


Open in Gitpod

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label Aug 11, 2022
@ghost ghost added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Aug 11, 2022
@vihdzp vihdzp added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label Apr 8, 2023
@vihdzp vihdzp changed the title feat(set_theory/ordinal/cantor_normal_form): CNF as an association list refactor(set_theory/ordinal/cantor_normal_form): CNF as an association list Apr 8, 2023
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 17, 2023
@YaelDillies YaelDillies added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 20, 2023
@eric-wieser eric-wieser added the not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 label Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

awaiting-review The author would like community review of the PR merge-conflict Please `git merge origin/master` then a bot will remove this label. modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants