[Merged by Bors] - fix(*): add missing classical tactics and decidable arguments
#18277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
1 task
|
Thanks 🎉 If CI passes, please remove the label bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
…nto eric-wieser/classical-leakage-fixes
…nto eric-wieser/classical-leakage-fixes
…nto eric-wieser/classical-leakage-fixes
…nto eric-wieser/classical-leakage-fixes
…nto eric-wieser/classical-leakage-fixes
github-actions
bot
removed
the
awaiting-CI
|
bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 24, 2023
…8277) As discussed in [this Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/.60classical.60.20attribute.20leakage/near/282726128), the `classical` tactic is buggy in Mathlib3, and "leaks" into subsequent declarations. This doesn't port well, as the bug is fixed in lean 4. This PR installs a temporary hack to contain these leaks, fixes (some of) the correponding breakages, then reverts the hack. The result is that the new `classical` tactics in the diff are not needed in Lean 3, but will be needed in Lean 4. In a future PR, I will try committing the hack itself; but in the meantime, these files are very close to (if not beyond) the port, so the sooner they are fixed the better.
…nto eric-wieser/classical-leakage-fixes
|
Canceled. |
|
bors merge (that last commit only adds two files which I'm optimistic about) |
bors bot
pushed a commit
that referenced
this pull request
Jan 24, 2023
…8277) As discussed in [this Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/.60classical.60.20attribute.20leakage/near/282726128), the `classical` tactic is buggy in Mathlib3, and "leaks" into subsequent declarations. This doesn't port well, as the bug is fixed in lean 4. This PR installs a temporary hack to contain these leaks, fixes all of the correponding breakages, then reverts the hack. The result is that the new `classical` tactics in the diff are not needed in Lean 3, but will be needed in Lean 4. In a future PR, I will try committing the hack itself; but in the meantime, these files are very close to (if not beyond) the port, so the sooner they are fixed the better.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
classical tactics and decidable argumentsclassical tactics and decidable arguments
eric-wieser
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 1, 2023
This forward-ports: * leanprover-community/mathlib#18277. No action is needed as the proof was already fixed during porting. * leanprover-community/mathlib#18337. This was forward-ported in #1970 but the SHA was not updated. See the diff here: * [`data.fintype.basic`@`9003f28797c0664a49e4179487267c494477d853`..`d78597269638367c3863d40d45108f52207e03cf`](https://leanprover-community.github.io/mathlib-port-status/file/data/fintype/basic?range=9003f28797c0664a49e4179487267c494477d853..d78597269638367c3863d40d45108f52207e03cf)
This was referenced Mar 1, 2023
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 5, 2023
This forward-ports: * leanprover-community/mathlib#18277. No action is needed as the proof was already fixed during porting. * leanprover-community/mathlib#18337. This was forward-ported in #1970 but the SHA was not updated. See the diff here: * [`data.fintype.basic`@`9003f28797c0664a49e4179487267c494477d853`..`d78597269638367c3863d40d45108f52207e03cf`](https://leanprover-community.github.io/mathlib-port-status/file/data/fintype/basic?range=9003f28797c0664a49e4179487267c494477d853..d78597269638367c3863d40d45108f52207e03cf)
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 6, 2023
leanprover-community/mathlib#18277 backported a bug about classical which is already fixed in mathlib4, so these diffs simpy need a SHA update. (Comment: This might not be the full PR #18277 yet, as I worked on a file-by-file base)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in this Zulip thread, the
classicaltactic is buggy in Mathlib3, and "leaks" into subsequent declarations.This doesn't port well, as the bug is fixed in lean 4.
This PR installs a temporary hack to contain these leaks, fixes all of the correponding breakages, then reverts the hack.
The result is that the new
classicaltactics in the diff are not needed in Lean 3, but will be needed in Lean 4.In a future PR, I will try committing the hack itself; but in the meantime, these files are very close to (if not beyond) the port, so the sooner they are fixed the better.