[Merged by Bors] - feat: update SHA from #18277 #2653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joneugster
added
awaiting-review
joneugster
removed
the
easy
joneugster
commented
Mar 5, 2023
joneugster
commented
Mar 5, 2023
|
bors r+ |
github-actions
bot
added
ready-to-merge
eric-wieser
reviewed
Mar 6, 2023
| @@ -61,8 +60,7 @@ theorem image_subtype_ne_univ_eq_image_erase [Fintype α] (k : β) (b : α → | |||
| exact ⟨⟨a, ne_of_mem_erase hi⟩, mem_univ _, rfl⟩ | |||
| #align image_subtype_ne_univ_eq_image_erase image_subtype_ne_univ_eq_image_erase | |||
|
|
|||
| open Classical in | |||
There was a problem hiding this comment.
This pattern is probably bad for any theorems in mathlib 4; at some point it would be worth looking for other occurrences; but not in this PR
bors bot
pushed a commit
that referenced
this pull request
Mar 6, 2023
leanprover-community/mathlib#18277 backported a bug about classical which is already fixed in mathlib4, so these diffs simpy need a SHA update. (Comment: This might not be the full PR #18277 yet, as I worked on a file-by-file base)
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
leanprover-community/mathlib#18277 backported a bug about classical which is already fixed in mathlib4, so these diffs simpy need a SHA update.
(Comment: This might not be the full PR #18277 yet, as I worked on a file-by-file base)
data.dfinsupp.basic@e3d9ab8faa9dea8f78155c6c27d62a621f4c152d..6623e6af705e97002a9054c1c05a980180276fc1data.finsupp.defs@8631e2d5ea77f6c13054d9151d82b83069680cb1..6623e6af705e97002a9054c1c05a980180276fc1data.pi.lex@d4f69d96f3532729da8ebb763f4bc26fcf640f06..6623e6af705e97002a9054c1c05a980180276fc1data.fintype.sum@509de852e1de55e1efa8eacfa11df0823f26f226..6623e6af705e97002a9054c1c05a980180276fc1order.order_iso_nat@2445c98ae4b87eabebdde552593519b9b6dc350c..6623e6af705e97002a9054c1c05a980180276fc1