Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analysis/calculus/mean_value): add generalized "fencing" inequality #1838

Merged
merged 13 commits into from Jan 9, 2020

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 29, 2019

I'm taking a 3-4 days break from Lean. After this I'll add missing
docstrings to this PR, go over review comments, then formalize
Gronwall inequality based on the general fencing theorem from this PR.

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@urkud urkud added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 2, 2020
This version can be used to deduce, e.g., Gronwall inequality as well
as its generalized version that deals with approximate solutions.
@urkud
Copy link
Member Author

urkud commented Jan 3, 2020

Rebased to resolve conflicts and simplify history.

@urkud urkud removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 3, 2020
@urkud urkud changed the title WIP feat(analysis/calculus/mean_value): add generalized "fencing" inequality feat(analysis/calculus/mean_value): add generalized "fencing" inequality Jan 3, 2020
@urkud urkud added this to Review in progress in Calculus / analysis Jan 3, 2020
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mathematical content is great, but documentation could still be improved. Notably, the file docstring of mean_value.lean should be updated. Also, there are various similar statements, close but slightly different. It would help to comment a little bit on the differences and the different use cases.

src/analysis/calculus/mean_value.lean Outdated Show resolved Hide resolved
src/analysis/calculus/mean_value.lean Outdated Show resolved Hide resolved
src/analysis/calculus/mean_value.lean Show resolved Hide resolved
@urkud
Copy link
Member Author

urkud commented Jan 6, 2020

I went over all docstrings and hopefully fixed them.

@sgouezel sgouezel added the awaiting-author A reviewer has asked the author a question or requested changes label Jan 8, 2020
@urkud urkud removed the awaiting-author A reviewer has asked the author a question or requested changes label Jan 9, 2020
@sgouezel sgouezel added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jan 9, 2020
Calculus / analysis automation moved this from Review in progress to Reviewer approved Jan 9, 2020
@mergify mergify bot merged commit 5289994 into master Jan 9, 2020
Calculus / analysis automation moved this from Reviewer approved to Done Jan 9, 2020
@mergify mergify bot deleted the fence branch January 9, 2020 02:47
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…ity (leanprover-community#1838)

* feat(analysis/calculus/mean_value): add generalized "fencing" inequality

This version can be used to deduce, e.g., Gronwall inequality as well
as its generalized version that deals with approximate solutions.

* Adjust to merged branches, use `liminf` instead of `limsup`, add more variations

* Go through dim-1 liminf estimates

* Fix: use `b ∈ Ioc a c` as a hypothesis for `I??_mem_nhds_within_Iio`

* Update src/analysis/calculus/mean_value.lean

Co-Authored-By: sgouezel <sebastien.gouezel@univ-rennes1.fr>

* Drop `Prop`-valued `variables`, add some docs

* More docstrings

* Drop `Prop`-valued `variables`, drop assumption `x ∉ s`.

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
…ity (leanprover-community#1838)

* feat(analysis/calculus/mean_value): add generalized "fencing" inequality

This version can be used to deduce, e.g., Gronwall inequality as well
as its generalized version that deals with approximate solutions.

* Adjust to merged branches, use `liminf` instead of `limsup`, add more variations

* Go through dim-1 liminf estimates

* Fix: use `b ∈ Ioc a c` as a hypothesis for `I??_mem_nhds_within_Iio`

* Update src/analysis/calculus/mean_value.lean

Co-Authored-By: sgouezel <sebastien.gouezel@univ-rennes1.fr>

* Drop `Prop`-valued `variables`, add some docs

* More docstrings

* Drop `Prop`-valued `variables`, drop assumption `x ∉ s`.

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants