[Merged by Bors] - chore(algebra/quaternion): generalize the algebra instance #18382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
2 tasks
eric-wieser
added
t-algebra
eric-wieser
force-pushed
the
eric-wieser/quaternion-algebra-generalize
branch
from
ecaf4ba
to
e7a90ef
Compare
eric-wieser
force-pushed
the
eric-wieser/quaternion-algebra-generalize
branch
from
e7a90ef
to
fadbbb6
Compare
github-actions
bot
removed
the
awaiting-CI
…ion-algebra-generalize
mathlib-dependent-issues-bot
added
the
blocked-by-other-PR
…' into eric-wieser/quaternion-algebra-generalize
eric-wieser
changed the base branch from
master
to
eric-wieser/quaternion-norm-cast
…' into eric-wieser/quaternion-algebra-generalize
bors
bot
changed the base branch from
eric-wieser/quaternion-norm-cast
to
master
mathlib-dependent-issues-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on:
|
YaelDillies
approved these changes
Feb 11, 2023
|
maintainer merge (since it didn't seem to post in the Zulip thread) |
|
🚀 Pull request has been placed on the maintainer queue by eric-wieser. |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
To prevent this generalization forming diamonds, we have to now populate the `nsmul`, `zsmul`, and `qsmul` fields. I use this in another PR to talk about the `R` algebra structure of `quaternion (dual_number R)`. Even without that motivation, this change means that the existing `smul` lemmas now apply to `nsmul`, `zsmul`, and `rat_smul` where previously they did not.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent this generalization forming diamonds, we have to now populate the
nsmul,zsmul, andqsmulfields.I use this in another PR to talk about the
Ralgebra structure ofquaternion (dual_number R).Even without that motivation, this change means that the existing
smullemmas now apply tonsmul,zsmul, andrat_smulwhere previously they did not.