Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(algebra/quaternion): missing trivial lemmas #18413

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - chore(algebra/quaternion): missing trivial lemmas #18413

wants to merge 8 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Feb 9, 2023 •
edited

A mixture of trivial algebraic results and trivial topological ones.

This also changes the rat.cast instance on quaternions to be slightly nicer.

Open in Gitpod

@eric-wieser eric-wieser force-pushed the eric-wieser/quaternion-norm-cast branch from 63e8dcc to cccda44 Compare February 9, 2023 19:47
@eric-wieser eric-wieser force-pushed the eric-wieser/quaternion-norm-cast branch from cccda44 to 02fa95a Compare February 9, 2023 19:47
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-topology Topological spaces, uniform spaces, metric spaces, filters t-algebra Algebra (groups, rings, fields etc) labels Feb 9, 2023
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 9, 2023
@eric-wieser eric-wieser mentioned this pull request Feb 9, 2023
Closed
6 tasks
YaelDillies
YaelDillies approved these changes Feb 9, 2023
View reviewed changes
src/algebra/quaternion.lean Outdated Show resolved Hide resolved
src/algebra/quaternion.lean Outdated Show resolved Hide resolved
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Feb 9, 2023
@eric-wieser eric-wieser mentioned this pull request Feb 9, 2023
Closed
1 task
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Feb 9, 2023
@ocfnash
Copy link
Collaborator

ocfnash commented Feb 10, 2023

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 10, 2023
bors bot pushed a commit that referenced this pull request Feb 10, 2023
@eric-wieser
chore(algebra/quaternion): missing trivial lemmas (#18413)
d3e3adc 
A mixture of trivial algebraic results and trivial topological ones.

This also changes the `rat.cast` instance on quaternions to be slightly nicer.
@bors
Copy link

bors bot commented Feb 10, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/quaternion): missing trivial lemmas [Merged by Bors] - chore(algebra/quaternion): missing trivial lemmas Feb 10, 2023
@bors bors bot closed this Feb 10, 2023
@bors bors bot deleted the eric-wieser/quaternion-norm-cast branch February 10, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc) t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eric-wieser @ocfnash @YaelDillies @mathlib-dependent-issues-bot