[Merged by Bors] - refactor(topology/*): add uniform_space.of_fun, use it
#18495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
YaelDillies
reviewed
Feb 26, 2023
urkud
changed the title
uniform_space.core.of_fun, use ituniform_space.of_fun, use it
YaelDillies
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
Looks good, but could someone who has used uniform spaces (@sgouezel, maybe?) check?
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Fix `simps` config for `absolute_value`. * Define `uniform_space.of_fun` and use it for `absolute_value.uniform_space`, `pseudo_emetric_space`, and `pseudo_metric_space`. * Add `filter.tendsto_infi_infi` and `filter.tendsto_supr_supr`. * Rename `pseudo_metric_space.of_metrizable` and `metric_space.of_metrizable` to `*.of_dist_topology`. * Add `metric.to_uniform_space_eq` and `metric.uniformity_basis_dist_rat`. * Migrate `topology.uniform_space.absolute_value` to bundled `absolute_value`.
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Fix `simps` config for `absolute_value`. * Define `uniform_space.of_fun` and use it for `absolute_value.uniform_space`, `pseudo_emetric_space`, and `pseudo_metric_space`. * Add `filter.tendsto_infi_infi` and `filter.tendsto_supr_supr`. * Rename `pseudo_metric_space.of_metrizable` and `metric_space.of_metrizable` to `*.of_dist_topology`. * Add `metric.to_uniform_space_eq` and `metric.uniformity_basis_dist_rat`. * Migrate `topology.uniform_space.absolute_value` to bundled `absolute_value`.
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Fix `simps` config for `absolute_value`. * Define `uniform_space.of_fun` and use it for `absolute_value.uniform_space`, `pseudo_emetric_space`, and `pseudo_metric_space`. * Add `filter.tendsto_infi_infi` and `filter.tendsto_supr_supr`. * Rename `pseudo_metric_space.of_metrizable` and `metric_space.of_metrizable` to `*.of_dist_topology`. * Add `metric.to_uniform_space_eq` and `metric.uniformity_basis_dist_rat`. * Migrate `topology.uniform_space.absolute_value` to bundled `absolute_value`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
uniform_space.of_fun, use ituniform_space.of_fun, use it
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 28, 2023
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simpsconfig forabsolute_value.uniform_space.of_funand use it forabsolute_value.uniform_space,pseudo_emetric_space, andpseudo_metric_space.filter.tendsto_infi_infiandfilter.tendsto_supr_supr.pseudo_metric_space.of_metrizableandmetric_space.of_metrizableto*.of_dist_topology.metric.to_uniform_space_eqandmetric.uniformity_basis_dist_rat.topology.uniform_space.absolute_valueto bundledabsolute_value.Most of the changes to the already ported files are backported from mathlib4 (or a pending PR to mathlib4). I'll sync the rest the day after this PR is merged.