Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: define UniformSpace.ofFun #2511

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: define UniformSpace.ofFun #2511

wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 27, 2023 •
edited

@urkud urkud added awaiting-review The author would like community review of the PR mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels Feb 27, 2023
jcommelin
jcommelin approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Feb 27, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Feb 27, 2023
@urkud urkud mentioned this pull request Feb 27, 2023
Closed
4 tasks
@urkud
Copy link
Member Author

urkud commented Feb 28, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Feb 28, 2023
bors bot pushed a commit that referenced this pull request Feb 28, 2023
@urkud
feat: define UniformSpace.ofFun (#2511)
0557adb 
Forward-port leanprover-community/mathlib#18495
@urkud
Copy link
Member Author

urkud commented Feb 28, 2023

bors r-

@bors
Copy link

bors bot commented Feb 28, 2023

Canceled.

@urkud
Copy link
Member Author

urkud commented Feb 28, 2023

bors merge

bors bot pushed a commit that referenced this pull request Feb 28, 2023
@urkud
feat: define UniformSpace.ofFun (#2511)
917b708 
Forward-port leanprover-community/mathlib#18495
@urkud urkud mentioned this pull request Feb 28, 2023
Closed
@bors
Copy link

bors bot commented Feb 28, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: define UniformSpace.ofFun [Merged by Bors] - feat: define UniformSpace.ofFun Feb 28, 2023
@bors bors bot closed this Feb 28, 2023
@bors bors bot deleted the YK-uniform-of-fun branch February 28, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @jcommelin @semorrison