Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(topology/metric_space): drop dist_setoid #18502

Closed
wants to merge 4 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 26, 2023

Use uniform_space.separation_setoid instead.


Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters labels Feb 26, 2023
@urkud urkud requested a review from sgouezel February 26, 2023 06:23
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

src/topology/metric_space/basic.lean Outdated Show resolved Hide resolved
src/topology/metric_space/gromov_hausdorff_realized.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Feb 26, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Feb 26, 2023
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@urkud
Copy link
Member Author

urkud commented Feb 26, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Feb 26, 2023
bors bot pushed a commit that referenced this pull request Feb 26, 2023
Use `uniform_space.separation_setoid` instead.
@bors
Copy link

bors bot commented Feb 27, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(topology/metric_space): drop dist_setoid [Merged by Bors] - refactor(topology/metric_space): drop dist_setoid Feb 27, 2023
@bors bors bot closed this Feb 27, 2023
@bors bors bot deleted the YK-dist-setoid branch February 27, 2023 00:20
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Feb 28, 2023
Some Mathlib 4 lemmas were backported to Mathlib 3 in leanprover-community/mathlib#18502, sync SHAs

* [`topology.uniform_space.separation`@`d90e4e186f1d18e375dcd4e5b5f6364b01cb3e46`..`0c1f285a9f6e608ae2bdffa3f993eafb01eba829`](https://leanprover-community.github.io/mathlib-port-status/file/topology/uniform_space/separation?range=d90e4e186f1d18e375dcd4e5b5f6364b01cb3e46..0c1f285a9f6e608ae2bdffa3f993eafb01eba829)
* [`topology.constructions`@`dc6c365e751e34d100e80fe6e314c3c3e0fd2988`..`0c1f285a9f6e608ae2bdffa3f993eafb01eba829`](https://leanprover-community.github.io/mathlib-port-status/file/topology/constructions?range=dc6c365e751e34d100e80fe6e314c3c3e0fd2988..0c1f285a9f6e608ae2bdffa3f993eafb01eba829)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants