[Merged by Bors] - refactor(ring_theory/ideal/operations): split quotients to a new file #18531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
reviewed
Mar 1, 2023
| @@ -8,6 +8,7 @@ import algebra.algebra.restrict_scalars | |||
| import algebra.algebra.subalgebra.basic | |||
| import group_theory.finiteness | |||
| import ring_theory.ideal.operations | |||
| import ring_theory.ideal.quotient | |||
There was a problem hiding this comment.
I think you can avoid this import by tweaking 1 proof a tiny little bit.
There was a problem hiding this comment.
Happy for me to do that as a follow-up? I agree that your proof in #18530 is nice here, but figure that it's fine to remain either in your PR or in another spin-off I can make tomorrow from https://github.com/leanprover-community/mathlib/tree/eric-wieser/finitenes-no-quotient (assuming it passes CI)
There was a problem hiding this comment.
Yes, please create a follow-up PR.
eric-wieser
added
awaiting-review
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
…#18531) This file is growing quite long. Splitting it will reduce dependencies in (some) downstream files, and by becoming shorter also makes this file easier to edit and port. This doesn't attempt to change any proofs in downstream files; instead, it just adds new imports to keep them compiling. There are 9 downstream files which no longer depend on the `quotient_operations` file, although one of these now depends on `ring_theory.ideal.quotient`. A future PR will remove the `ring_theory.ideal.quotient_operations` import from more files. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is growing quite long.
Splitting it will reduce dependencies in (some) downstream files, and by becoming shorter also makes this file easier to edit and port.
This doesn't attempt to change any proofs in downstream files; instead, it just adds new imports to keep them compiling.
There are 9 downstream files which no longer depend on the
quotient_operationsfile, although one of these now depends onring_theory.ideal.quotient.A future PR will remove the
ring_theory.ideal.quotient_operationsimport from more files.Split from #18530