Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(ring_theory/ideal/operations): split quotients to a new file #18531

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - refactor(ring_theory/ideal/operations): split quotients to a new file #18531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
29aba48
initial split
jcommelin Mar 1, 2023
61367cc
fix import
eric-wieser Mar 1, 2023
ce59cc3
more import fixes
eric-wieser Mar 1, 2023
cc3c9f9
fix import
eric-wieser Mar 1, 2023
c62cbd1
fix
eric-wieser Mar 1, 2023
dff7f54
fix import
eric-wieser Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/algebra/direct_limit.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Authors: Kenny Lau, Chris Hughes
import data.finset.order
import algebra.direct_sum.module
import ring_theory.free_comm_ring
import ring_theory.ideal.operations
import ring_theory.ideal.quotient_operations
/-!
# Direct limit of modules, abelian groups, rings, and fields.

Expand Down
1 change: 1 addition & 0 deletions src/analysis/normed/group/quotient.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Authors: Patrick Massot, Riccardo Brasca
-/
import analysis.normed_space.basic
import analysis.normed.group.hom
import ring_theory.ideal.quotient_operations

/-!
# Quotients of seminormed groups
Expand Down
1 change: 1 addition & 0 deletions src/ring_theory/finiteness.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import algebra.algebra.restrict_scalars
import algebra.algebra.subalgebra.basic
import group_theory.finiteness
import ring_theory.ideal.operations
import ring_theory.ideal.quotient
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can avoid this import by tweaking 1 proof a tiny little bit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for me to do that as a follow-up? I agree that your proof in #18530 is nice here, but figure that it's fine to remain either in your PR or in another spin-off I can make tomorrow from https://github.com/leanprover-community/mathlib/tree/eric-wieser/finitenes-no-quotient (assuming it passes CI)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please create a follow-up PR.


/-!
# Finiteness conditions in commutative algebra
Expand Down
499 changes: 1 addition & 498 deletions src/ring_theory/ideal/operations.lean
View file
Open in desktop

Large diffs are not rendered by default.

513 changes: 513 additions & 0 deletions src/ring_theory/ideal/quotient_operations.lean
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/ring_theory/localization/ideal.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Copyright (c) 2018 Kenny Lau. All rights reserved.
Released under Apache 2.0 license as described in the file LICENSE.
Authors: Kenny Lau, Mario Carneiro, Johan Commelin, Amelia Livingston, Anne Baanen
-/
import ring_theory.ideal.operations
import ring_theory.ideal.quotient_operations
import ring_theory.localization.basic

/-!
Expand Down
2 changes: 1 addition & 1 deletion src/ring_theory/nilpotent.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Authors: Oliver Nash
-/
import data.nat.choose.sum
import algebra.algebra.bilinear
import ring_theory.ideal.operations
import ring_theory.ideal.quotient_operations

/-!
# Nilpotent elements
Expand Down
2 changes: 1 addition & 1 deletion src/ring_theory/valuation/basic.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Authors: Kevin Buzzard, Johan Commelin, Patrick Massot
-/

import algebra.order.with_zero
import ring_theory.ideal.operations
import ring_theory.ideal.quotient_operations

/-!

Expand Down