Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(*): various simple lemmas about *_equiv, add missing attrs #1854

Merged
merged 3 commits into from Jan 6, 2020
Merged

chore(*): various simple lemmas about *_equiv, add missing attrs #1854

merged 3 commits into from Jan 6, 2020

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 5, 2020

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@sgouezel sgouezel added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jan 6, 2020
@mergify mergify bot merged commit 15c434a into master Jan 6, 2020
@mergify mergify bot deleted the assorted-lemmas branch January 6, 2020 03:50
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
@urkud @mergify @anrddh
chore(*): various simple lemmas about *_equiv, add missing attrs (l…
af09f01 
…eanprover-community#1854)

* chore(*): various simple lemmas about `*_equiv`, add missing attrs

* Fix compile of `ring_theory/localization`

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
@urkud @mergify @anrddh
chore(*): various simple lemmas about *_equiv, add missing attrs (l…
666a883 
…eanprover-community#1854)

* chore(*): various simple lemmas about `*_equiv`, add missing attrs

* Fix compile of `ring_theory/localization`

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @sgouezel