New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(algebra/order/nonneg/*): Separate floor_ring
from field
#18596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
The author would like community review of the PR
t-algebra
Algebra (groups, rings, fields etc)
t-order
Order hierarchy
labels
Mar 16, 2023
11 tasks
eric-wieser
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
Thanks!
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
The PR author may merge after reviewing final suggestions.
and removed
awaiting-review
The author would like community review of the PR
labels
Mar 16, 2023
eric-wieser
added
awaiting-review
The author would like community review of the PR
modifies-synchronized-file
This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR.
and removed
delegated
The PR author may merge after reviewing final suggestions.
labels
Mar 16, 2023
bors merge |
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Mar 16, 2023
bors bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
…8596) Move the `archimedean` and `floor_ring` instances out of `algebra.order.nonneg.field` into a new file `algebra.order.nonneg.floor`.
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
chore(algebra/order/nonneg/*): Separate
[Merged by Bors] - chore(algebra/order/nonneg/*): Separate Mar 16, 2023
floor_ring
from field
floor_ring
from field
1 task
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 17, 2023
Match leanprover-community/mathlib#18590 and leanprover-community/mathlib#18596 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 17, 2023
Match leanprover-community/mathlib#18590 and leanprover-community/mathlib#18596 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
modifies-synchronized-file
This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR.
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
t-algebra
Algebra (groups, rings, fields etc)
t-order
Order hierarchy
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
archimedean
andfloor_ring
instances out ofalgebra.order.nonneg.field
into a new filealgebra.order.nonneg.floor
.This is crucial for unmangling imports and defining
nnrat.cast
in #16554.