feat(algebra/field/basic): nnrat.cast
#16554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
WIP
|
@semorrison, here is the source of my splitting ideas. Basically it's:
|
mathlib-dependent-issues-bot
added
the
blocked-by-other-PR
eric-wieser
reviewed
Mar 16, 2023
Closed
1 task
mathlib-dependent-issues-bot
removed
the
blocked-by-other-PR
eric-wieser
reviewed
Mar 18, 2023
src/algebra/group_power/lemmas.lean
Outdated
There was a problem hiding this comment.
The changes to this file are unrelated cleanup, right?
eric-wieser
reviewed
Mar 18, 2023
| @@ -143,6 +143,8 @@ alias even.zpow_pos_iff ↔ _ even.zpow_pos | |||
| alias odd.zpow_neg_iff ↔ _ odd.zpow_neg | |||
| alias odd.zpow_nonpos_iff ↔ _ odd.zpow_nonpos | |||
|
|
|||
| @[simp] lemma abs_zpow (a : α) (n : ℤ) : |a ^ n| = |a| ^ n := map_zpow₀ (abs_hom : α →*₀ α) a n | |||
There was a problem hiding this comment.
This feels like a weird place for this lemma; do we have abs_inv and abs_div already that it could go next to?
There was a problem hiding this comment.
We do have the lemmas in algebra.order.field.basic, but map_zpow₀ isn't available there. Also note that algebra.order.field.power is precisely about zpow and nothing else.
There was a problem hiding this comment.
Ah, in which case I'll reduce my comment to "surely this doesn't belong in this PR"!
eric-wieser
reviewed
Mar 18, 2023
mathlib-dependent-issues-bot
added
the
blocked-by-other-PR
semorrison
added
the
too-late
eric-wieser
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 5, 2024
…ditive monoids While many of the lemmas cease to apply, the definitions of sequences and their sums are still perfectly well-behaved in additive monoids; no negation is needed. We could use this to generalize `NormedSpace.exp` such that it works with `NNReal`, but unless leanprover-community/mathlib#16554 or similar lands and provides a `DivisionSemiring.nnqsmul` field, that would conflict with #8370.
mathlib-dependent-issues-bot
removed
the
blocked-by-other-PR
|
Redone in leanprover-community/mathlib4#11203. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define the canonical coercion
ℚ≥0 → αwhereαis adivision_semiring. This involves a lot of import shuffling.The new fields are
ringandfieldinstances #17348int.castinstead ofrat.of_int#17392pow_minus_two_nonneg#18591floor_ringfromfield#18596divlemmas #18607