-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(algebra/*/opposite): Missing instances #18602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
The author would like community review of the PR
t-algebra
Algebra (groups, rings, fields etc)
labels
Mar 16, 2023
This was referenced Mar 16, 2023
eric-wieser
reviewed
Mar 17, 2023
eric-wieser
reviewed
Mar 17, 2023
eric-wieser
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Mar 17, 2023
YaelDillies
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Mar 17, 2023
eric-wieser
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Thanks! I edited the description mention the defeq of rat.cast
leanprover-community-bot-assistant
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Mar 17, 2023
bors bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
A few missing instances about `nat.cast`/`int.cast`/`rat.cast` and `mul_opposite`/`add_opposite`. Also add the (weirdly) missing `add_comm_group_with_one → add_comm_monoid_with_one`. Finally, this changes the defeq of `rat.cast` on `mul_opposite` to be simpler.
Build failed: |
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
A few missing instances about `nat.cast`/`int.cast`/`rat.cast` and `mul_opposite`/`add_opposite`. Also add the (weirdly) missing `add_comm_group_with_one → add_comm_monoid_with_one`. Finally, this changes the defeq of `rat.cast` on `mul_opposite` to be simpler.
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(algebra/*/opposite): Missing instances
[Merged by Bors] - feat(algebra/*/opposite): Missing instances
Mar 17, 2023
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 24, 2023
Match leanprover-community/mathlib#18602 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
t-algebra
Algebra (groups, rings, fields etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few missing instances about
nat.cast
/int.cast
/rat.cast
andmul_opposite
/add_opposite
.Also add the (weirdly) missing
add_comm_group_with_one → add_comm_monoid_with_one
.Finally, this changes the defeq of
rat.cast
onmul_opposite
to be simpler.Match leanprover-community/mathlib4#2940