Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(order/category): Partially revert categories #18690

Closed
wants to merge 1 commit into from

Conversation

Parcly-Taxel
Copy link
Collaborator

It was pointed out in leanprover-community/mathlib4#3164 that certain changes in #18657 were unsound. This PR reverts those unsound changes.


Open in Gitpod

Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry...

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@semorrison
Copy link
Collaborator

Sorry, I think I merged that one too quickly!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 29, 2023
bors bot pushed a commit that referenced this pull request Mar 30, 2023
It was pointed out in leanprover-community/mathlib4#3164 that certain changes in #18657 were unsound. This PR reverts those unsound changes.



Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Mar 30, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(order/category): Partially revert categories [Merged by Bors] - chore(order/category): Partially revert categories Mar 30, 2023
@bors bors bot closed this Mar 30, 2023
@bors bors bot deleted the 18657-2 branch March 30, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-category-theory Category theory t-order Order hierarchy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants