Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: forward port leanprover-community/mathlib#18657 #3164

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore: forward port leanprover-community/mathlib#18657 #3164

wants to merge 3 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

@Parcly-Taxel Parcly-Taxel commented Mar 29, 2023 •
edited

@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels Mar 29, 2023
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 29, 2023
@Parcly-Taxel Parcly-Taxel mentioned this pull request Mar 29, 2023
Closed
@Parcly-Taxel Parcly-Taxel added blocked-by-other-PR This PR depends on another PR which is still in the queue. awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Mar 29, 2023
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Mar 30, 2023
@Parcly-Taxel
chore(order/category): Partially revert categories (#18690)
71b36b6 
It was pointed out in leanprover-community/mathlib4#3164 that certain changes in #18657 were unsound. This PR reverts those unsound changes.



Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Mar 30, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 30, 2023
bors bot pushed a commit that referenced this pull request Mar 30, 2023
@Parcly-Taxel
chore: forward port leanprover-community/mathlib#18657 (#3164)
c367fef 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Mar 30, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore: forward port leanprover-community/mathlib#18657 [Merged by Bors] - chore: forward port leanprover-community/mathlib#18657 Mar 30, 2023
@bors bors bot closed this Mar 30, 2023
@bors bors bot deleted the 18657 branch March 30, 2023 06:38
joelriou pushed a commit that referenced this pull request Mar 30, 2023
@Parcly-Taxel @joelriou
chore: forward port leanprover-community/mathlib#18657 (#3164)
ed1e7f7 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@Parcly-Taxel @MonadMaverick
chore: forward port leanprover-community/mathlib#18657 (#3164)
6785d2d 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@Parcly-Taxel @MonadMaverick
chore: forward port leanprover-community/mathlib#18657 (#3164)
458740c 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

Assignees
No one assigned
Labels
mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Parcly-Taxel @semorrison