Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(group_theory/subgroup/basic): Protect subgroup.subtype #18712

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(group_theory/subgroup/basic): Protect subgroup.subtype #18712

wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Apr 1, 2023 •
edited

and subgroup_class.subtype. This was breaking the subtype notation for me in #18684. The longer term fix would be to add a _root_ in the notation declaration.

Open in Gitpod

@YaelDillies YaelDillies added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. t-algebra Algebra (groups, rings, fields etc) labels Apr 1, 2023
@YaelDillies YaelDillies mentioned this pull request Apr 1, 2023
Closed
4 tasks
@eric-wieser
Copy link
Member

eric-wieser commented Apr 2, 2023 •
edited

Is submodule.subtype already protected?

Edit: yes,

mathlib/src/algebra/module/submodule/basic.lean

Line 154 in 88fcb83

protected def subtype : S' →ₗ[R] M := ⟨coe, λ _ _, rfl, λ _ _, rfl⟩

eric-wieser
eric-wieser approved these changes Apr 2, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 2, 2023
bors bot pushed a commit that referenced this pull request Apr 2, 2023
@YaelDillies
chore(group_theory/subgroup/basic): Protect subgroup.subtype (#18712)
6b60020 
and `subgroup_class.subtype`. This was breaking the `subtype` notation for me in #18684. The longer term fix would be to add a `_root_` in the notation declaration.
@bors
Copy link

bors bot commented Apr 2, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(group_theory/subgroup/basic): Protect subgroup.subtype [Merged by Bors] - chore(group_theory/subgroup/basic): Protect subgroup.subtype Apr 2, 2023
@bors bors bot closed this Apr 2, 2023
@bors bors bot deleted the protect_subgroup_subtype branch April 2, 2023 11:49
@vihdzp vihdzp mentioned this pull request Apr 4, 2023
Closed
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Apr 9, 2023
@vihdzp
feat: protect Subgroup.subtype (#3254)
f3bf772 
Mathlib 3: leanprover-community/mathlib#18712
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Apr 9, 2023
@vihdzp
feat: protect Subgroup.subtype (#3254)
a8db3aa 
Mathlib 3: leanprover-community/mathlib#18712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @eric-wieser @leanprover-community-bot-assistant