Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: protect Subgroup.subtype #3254

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat: protect Subgroup.subtype #3254

wants to merge 1 commit into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Apr 4, 2023

@vihdzp vihdzp added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels Apr 4, 2023
@vihdzp vihdzp requested a review from YaelDillies April 4, 2023 02:12
YaelDillies
YaelDillies approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! But you didn't have to. I was about to open it (and couldn't do it before because mathport ran on it overnight).

Just noting that coe_pow and coe_zpow didn't have to change because their proofs became rfl during the port.

Mathlib/GroupTheory/Subgroup/Basic.lean
@@ -802,7 +802,7 @@ theorem coeSubtype : ⇑ H.subtype = ((↑) : H → G) :=
#align add_subgroup.coe_subtype AddSubgroup.coeSubtype

@[to_additive]
theorem subtype_injective : Function.Injective (subtype H) :=
theorem subtype_injective : Function.Injective (Subgroup.subtype H) :=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
theorem subtype_injective : Function.Injective (Subgroup.subtype H) :=
theorem subtype_injective : Injective (Subgroup.subtype H) :=

@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 9, 2023
bors bot pushed a commit that referenced this pull request Apr 9, 2023
@vihdzp
feat: protect Subgroup.subtype (#3254)
f3bf772 
Mathlib 3: leanprover-community/mathlib#18712
bors bot pushed a commit that referenced this pull request Apr 9, 2023
@vihdzp
feat: protect Subgroup.subtype (#3254)
a8db3aa 
Mathlib 3: leanprover-community/mathlib#18712
@bors
Copy link

bors bot commented Apr 9, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: protect Subgroup.subtype [Merged by Bors] - feat: protect Subgroup.subtype Apr 9, 2023
@bors bors bot closed this Apr 9, 2023
@bors bors bot deleted the subgroup_subtype branch April 9, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vihdzp @ChrisHughes24 @YaelDillies