chore(*): use ne_ instead of neq_ in lemma names
#1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One exception: `mem_sets_of_neq_bot` is now `mem_sets_of_eq_bot` because it has an equality as an assumption. Also add `filter.infi_ne_bot_(iff_?)of_directed'` with a different `nonempty` assumption, and use it to simplify the proof of `lift_ne_bot_iff`.
sgouezel
added
the
ready-to-merge
sgouezel
approved these changes
Jan 15, 2020
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…unity#1878) One exception: `mem_sets_of_neq_bot` is now `mem_sets_of_eq_bot` because it has an equality as an assumption. Also add `filter.infi_ne_bot_(iff_?)of_directed'` with a different `nonempty` assumption, and use it to simplify the proof of `lift_ne_bot_iff`. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…unity#1878) One exception: `mem_sets_of_neq_bot` is now `mem_sets_of_eq_bot` because it has an equality as an assumption. Also add `filter.infi_ne_bot_(iff_?)of_directed'` with a different `nonempty` assumption, and use it to simplify the proof of `lift_ne_bot_iff`. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One exception:
mem_sets_of_neq_botis nowmem_sets_of_eq_botbecause it has an equality as an assumption.
Also add
filter.infi_ne_bot_(iff_?)of_directed'with a differentnonemptyassumption, and use it to simplify the proof oflift_ne_bot_iff.TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list