refactor(order/filter/basic): redefine filter.pure
#1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New definition has `s ∈ pure a` definitionally equal to `a ∈ s`.
gebner
reviewed
Jan 21, 2020
gebner
reviewed
Jan 21, 2020
|
Looks good to me aside from the minor stuff. I have no opinion on changing the definition of |
Co-Authored-By: Gabriel Ebner <gebner@gebner.org>
sgouezel
added
awaiting-author
…ty/mathlib into filter-pure-def
urkud
added
awaiting-review
sgouezel
reviewed
Jan 26, 2020
sgouezel
added
ready-to-merge
sgouezel
approved these changes
Jan 26, 2020
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…unity#1889) * refactor(order/filter/basic): redefine `filter.pure` New definition has `s ∈ pure a` definitionally equal to `a ∈ s`. * Update src/order/filter/basic.lean Co-Authored-By: Gabriel Ebner <gebner@gebner.org> * Minor fixes suggested by @gebner * Fix compile * Update src/order/filter/basic.lean Co-authored-by: Gabriel Ebner <gebner@gebner.org> Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…unity#1889) * refactor(order/filter/basic): redefine `filter.pure` New definition has `s ∈ pure a` definitionally equal to `a ∈ s`. * Update src/order/filter/basic.lean Co-Authored-By: Gabriel Ebner <gebner@gebner.org> * Minor fixes suggested by @gebner * Fix compile * Update src/order/filter/basic.lean Co-authored-by: Gabriel Ebner <gebner@gebner.org> Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New definition has
s ∈ pure adefinitionally equal toa ∈ s.TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list