Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(number_theory/modular_forms/slash_actions): slash actions are families of distrib_mul_actions #18932

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented May 3, 2023

This replaces the bespoke slash_action β G α γ typeclass with:

  • Π b : β, distrib_mul_action (slash_act G b) α for the action itself, where slash_act G b is a type alias of mul_opposite (to allow for right actions)
  • smul_comm_class (slash_act G k) γ α for compatibility with the γ action

This means compatibility with multiple types simultaneously is possible, and that f ∣[k;γ] A notation can be discarded.

This keeps around slash_action.map k A f to provide f ∣[k] A notation, but it's now reducibly equal to slash_act.of k A • f


Open in Gitpod

It's not immediately clear that the switch to using distrib_mul_action is worth it, but this does at least prove it can be done.

@eric-wieser eric-wieser added WIP Work in progress awaiting-CI The author would like to see what CI has to say before doing more work. labels May 3, 2023
@eric-wieser eric-wieser added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label May 3, 2023
@eric-wieser eric-wieser force-pushed the eric-wieser/slash_action.redo branch from e769b8a to 25af56d Compare May 4, 2023 21:34
@eric-wieser eric-wieser added RFC Request for comment and removed WIP Work in progress labels May 4, 2023
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label May 10, 2023
@semorrison semorrison added the too-late This PR was ready too late for inclusion in mathlib3 label Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request for comment t-number-theory Number theory (also use t-algebra or t-analysis to specialize) too-late This PR was ready too late for inclusion in mathlib3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants