[Merged by Bors] - chore(topology/instances/ennreal): missing smul lemmas #18980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eric-wieser
commented
May 10, 2023
eric-wieser
commented
eric-wieser
added
easy
eric-wieser
changed the title
github-actions
bot
added
the
modifies-synchronized-file
5 tasks
fpvandoorn
reviewed
May 10, 2023
| @@ -388,6 +388,14 @@ begin split_ifs, { simp [h] }, { exact with_top.top_mul h } end | |||
|
|
|||
| @[simp] lemma top_mul_top : ∞ * ∞ = ∞ := with_top.top_mul_top | |||
|
|
|||
| lemma smul_top {R} [has_zero R] [smul_with_zero R ℝ≥0∞] [is_scalar_tower R ℝ≥0∞ ℝ≥0∞] | |||
There was a problem hiding this comment.
maybe generalize to an arbitrary with_top lemma?
Otherwise, LGTM
There was a problem hiding this comment.
The smul instances aren't generalized to with_top right now, so I can't do that without moving a lot of stuff. I'll leave a TODO comment.
|
bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
👎 Rejected by label |
leanprover-community-bot-assistant
added
the
ready-to-merge
eric-wieser
removed
the
awaiting-CI
|
bors merge |
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
eric-wieser
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 13, 2023
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 22, 2023
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
qawbecrdtey
pushed a commit
to qawbecrdtey/greedoid-mathlib4
that referenced
this pull request
Jun 12, 2023
…mmunity#3956) Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.