Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: forward-port leanprover-community/mathlib#18980 #3956

Closed
wants to merge 7 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented May 13, 2023

@eric-wieser eric-wieser added the mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged label May 13, 2023
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label May 13, 2023
@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels May 14, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 14, 2023
@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label May 15, 2023
@ADedecker
Copy link
Member

I'm not sure how to check that all SHAs are as they should be, otherwise LGTM.

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by ADedecker.

@eric-wieser
Copy link
Member Author

I'm not sure how to check that all SHAs are as they should be, otherwise LGTM.

If you look at the file diff view, a bot leaves an annotation with a link to check for each file

@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 22, 2023
bors bot pushed a commit that referenced this pull request May 22, 2023
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@bors
Copy link

bors bot commented May 22, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: forward-port leanprover-community/mathlib#18980 [Merged by Bors] - chore: forward-port leanprover-community/mathlib#18980 May 22, 2023
@bors bors bot closed this May 22, 2023
@bors bors bot deleted the forward-port-18980 branch May 22, 2023 12:09
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
…mmunity#3956)

Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants