feat(*): some simple lemmas about sets and finite sets #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
jcommelin
reviewed
Jan 25, 2020
urkud
added
awaiting-author
Co-Authored-By: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
This reverts commit 17c89a8. It breaks compile if we rewrite right to left.
sgouezel
added
ready-to-merge
sgouezel
reviewed
Jan 25, 2020
There was a problem hiding this comment.
This is good for me. @ChrisHughes24 , if you are happy, you get set this to ready to merge.
ChrisHughes24
approved these changes
Jan 25, 2020
ChrisHughes24
added
ready-to-merge
sgouezel
reviewed
Jan 25, 2020
| exact fin.cases (or.inl rfl) (λ i, or.inr ⟨i, trivial, rfl⟩) m | ||
| end | ||
|
|
||
| theorem fin.prod_univ_succ [comm_monoid β] {n:ℕ} (f : fin n.succ → β) : |
There was a problem hiding this comment.
Maybe add a comment why this does not work with to_additive (I guess this is because of the 0?) and that the to_additive version will be registered in fin.sum_univ_succ.
There was a problem hiding this comment.
As far as I understand, it's because +1 is used somewhere in the proof, and to_additive tries to replace it with +0.
4 tasks
robertylewis
added a commit
that referenced
this pull request
Jan 27, 2020
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…mmunity#1903) * feat(*): some simple lemmas about sets and finite sets * More lemmas, simplify proofs * Introduce `finsup.nonempty` and use it. * Update src/algebra/big_operators.lean Co-Authored-By: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com> * Revert "Update src/algebra/big_operators.lean" This reverts commit 17c89a8. It breaks compile if we rewrite right to left. * simp, to_additive * Add a missing docstring Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…mmunity#1903) * feat(*): some simple lemmas about sets and finite sets * More lemmas, simplify proofs * Introduce `finsup.nonempty` and use it. * Update src/algebra/big_operators.lean Co-Authored-By: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com> * Revert "Update src/algebra/big_operators.lean" This reverts commit 17c89a8. It breaks compile if we rewrite right to left. * simp, to_additive * Add a missing docstring Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list