Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(data/set/function): use dot notation, rename and add some lemmas #1934

Merged
merged 3 commits into from Feb 13, 2020
Merged

refactor(data/set/function): use dot notation, rename and add some lemmas #1934

merged 3 commits into from Feb 13, 2020

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 31, 2020

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@urkud
Copy link
Member Author

urkud commented Feb 1, 2020

This PR contains several loosely related changes. I'll split it into smaller reviewable pieces.

@urkud urkud added the WIP Work in progress label Feb 1, 2020
@urkud urkud added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Feb 13, 2020
robertylewis
robertylewis approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@robertylewis robertylewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, except for the merge conflict!

@urkud
Copy link
Member Author

urkud commented Feb 13, 2020

@robertylewis Fixed merge conflict.

@robertylewis robertylewis changed the title refactor(data/set/function): use dot notation, add some lemmas refactor(data/set/function): use dot notation, rename and add some lemmas Feb 13, 2020
@robertylewis robertylewis added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 13, 2020
@mergify mergify bot merged commit db1c500 into master Feb 13, 2020
@mergify mergify bot deleted the set-function branch February 13, 2020 22:28
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
@urkud @mergify @anrddh
refactor(data/set/function): use dot notation (leanprover-community#1934
219b941 
)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
@urkud @mergify @anrddh
refactor(data/set/function): use dot notation (leanprover-community#1934
bf94726 
)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertylewis robertylewis robertylewis approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @robertylewis