Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data/set/basic): define set.subsingleton #1939

Merged
merged 3 commits into from
Feb 2, 2020
Merged

feat(data/set/basic): define set.subsingleton #1939

merged 3 commits into from
Feb 2, 2020

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 1, 2020

Also rename nonempty.of_subset to nonempty.mono

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

Also rename `nonempty.of_subset` to `nonempty.mono`
@urkud urkud added the awaiting-review The author would like community review of the PR label Feb 2, 2020
@sgouezel sgouezel added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 2, 2020
@mergify mergify bot merged commit 58899d4 into master Feb 2, 2020
@mergify mergify bot deleted the set-basic branch February 2, 2020 10:50
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…#1939)

* feat(data/set/basic): define `set.subsingleton`

Also rename `nonempty.of_subset` to `nonempty.mono`

* Add a missing lemma

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
…#1939)

* feat(data/set/basic): define `set.subsingleton`

Also rename `nonempty.of_subset` to `nonempty.mono`

* Add a missing lemma

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants