refactor(data/matrix,linear_algebra): Use matrix.mul as default multiplication in matrix lemmas
#1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vierkantor
added a commit
to Vierkantor/mathlib
that referenced
this pull request
Feb 5, 2020
That PR changes `det_mul` to have another, still definitionally equal, type. If the invocations to `det_mul` are independent of syntactic equality, i.e. we only pass `det_mul` to `erw`, this branch should be compatible with the state before the change and after.
jcommelin
approved these changes
Feb 5, 2020
4 tasks
robertylewis
added
the
awaiting-review
mergify bot
added a commit
that referenced
this pull request
Feb 8, 2020
* Define the special linear group * Make definitions independent of PR #1959 That PR changes `det_mul` to have another, still definitionally equal, type. If the invocations to `det_mul` are independent of syntactic equality, i.e. we only pass `det_mul` to `erw`, this branch should be compatible with the state before the change and after. * Documentation and code style improvements * Improve module docstring * Fix documentation `matrix.special_linear_group` is not a set but a type Co-Authored-By: sgouezel <sebastien.gouezel@univ-rennes1.fr> * Don't directly coerce from SL to linear maps Now we coerce from `matrix.special_linear_group n R` to `matrix n n R` instead of `general_linear_group R (n -> R)` * Whitespace fixes * Fix failing build in `src/linear_algebra/dual.lean` * Give an almost generic formula for `det_adjugate` * Move `det_eq_one_of_card_eq_zero` to the correct section * Replace the ad-hoc assumption of `det_adjugate_of_invertible` with `is_unit` * Fix linting error There was an unnecessary assumption [decidable_eq α] floating around * Replace `special_linear_group.val` with the appropriate coercions * whitespace Correctly indent continued line Co-Authored-By: sgouezel <sebastien.gouezel@univ-rennes1.fr> * Docstrings for the `det_adjugate_of_...` lemmas Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sgouezel
added
ready-to-merge
ChrisHughes24
approved these changes
Feb 9, 2020
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…ommunity#1960) * Define the special linear group * Make definitions independent of PR leanprover-community#1959 That PR changes `det_mul` to have another, still definitionally equal, type. If the invocations to `det_mul` are independent of syntactic equality, i.e. we only pass `det_mul` to `erw`, this branch should be compatible with the state before the change and after. * Documentation and code style improvements * Improve module docstring * Fix documentation `matrix.special_linear_group` is not a set but a type Co-Authored-By: sgouezel <sebastien.gouezel@univ-rennes1.fr> * Don't directly coerce from SL to linear maps Now we coerce from `matrix.special_linear_group n R` to `matrix n n R` instead of `general_linear_group R (n -> R)` * Whitespace fixes * Fix failing build in `src/linear_algebra/dual.lean` * Give an almost generic formula for `det_adjugate` * Move `det_eq_one_of_card_eq_zero` to the correct section * Replace the ad-hoc assumption of `det_adjugate_of_invertible` with `is_unit` * Fix linting error There was an unnecessary assumption [decidable_eq α] floating around * Replace `special_linear_group.val` with the appropriate coercions * whitespace Correctly indent continued line Co-Authored-By: sgouezel <sebastien.gouezel@univ-rennes1.fr> * Docstrings for the `det_adjugate_of_...` lemmas Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…tiplication in matrix lemmas (leanprover-community#1959) * Change `has_mul.mul` to `matrix.mul` in a few `simp` lemmas * Standardise more lemmas for matrix multiplication * Generalize `to_pequiv_mul_matrix` to rectangular matrices Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…ommunity#1960) * Define the special linear group * Make definitions independent of PR leanprover-community#1959 That PR changes `det_mul` to have another, still definitionally equal, type. If the invocations to `det_mul` are independent of syntactic equality, i.e. we only pass `det_mul` to `erw`, this branch should be compatible with the state before the change and after. * Documentation and code style improvements * Improve module docstring * Fix documentation `matrix.special_linear_group` is not a set but a type Co-Authored-By: sgouezel <sebastien.gouezel@univ-rennes1.fr> * Don't directly coerce from SL to linear maps Now we coerce from `matrix.special_linear_group n R` to `matrix n n R` instead of `general_linear_group R (n -> R)` * Whitespace fixes * Fix failing build in `src/linear_algebra/dual.lean` * Give an almost generic formula for `det_adjugate` * Move `det_eq_one_of_card_eq_zero` to the correct section * Replace the ad-hoc assumption of `det_adjugate_of_invertible` with `is_unit` * Fix linting error There was an unnecessary assumption [decidable_eq α] floating around * Replace `special_linear_group.val` with the appropriate coercions * whitespace Correctly indent continued line Co-Authored-By: sgouezel <sebastien.gouezel@univ-rennes1.fr> * Docstrings for the `det_adjugate_of_...` lemmas Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…tiplication in matrix lemmas (leanprover-community#1959) * Change `has_mul.mul` to `matrix.mul` in a few `simp` lemmas * Standardise more lemmas for matrix multiplication * Generalize `to_pequiv_mul_matrix` to rectangular matrices Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Zulip, some
simplemmas for matrices usehas_mul.mul, others (the vast majority, it turns out when making this PR) usematrix.mul. Since we agreed that rewriting frommatrix.multohas_mul.mulcan cause problems, I decided to be bold and make this PR.This PR standardises the lemmas for matrices to use
matrix.mul. It also standardises the naming where there is a pair of lemmas:foousesmatrix.mulandfoo'useshas_mul.mul. Both changes make a few exceptions fit in with the majority of existing definitions.TO CONTRIBUTORS:
Make sure you have:
For reviewers: code review check list