refactor(order/bounds): use dot notation, reorder, prove more properties #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make parts of `complete_lattice` and `conditionally_complete_lattice` use these lemmas.
sgouezel
reviewed
Feb 20, 2020
sgouezel
reviewed
Feb 23, 2020
urkud
added
awaiting-author
urkud
added
awaiting-review
sgouezel
reviewed
Feb 25, 2020
sgouezel
approved these changes
Feb 25, 2020
sgouezel
added
ready-to-merge
7 tasks
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…ies (leanprover-community#2028) * refactor(order/bounds): use dot notation, prove more properties Also make parts of `complete_lattice` and `conditionally_complete_lattice` use these lemmas. * Comments * Add a module docstring * Fixes from review, +4 lemmas about images * Fix a typo in the previous commit * Update src/order/bounds.lean * Update src/order/bounds.lean Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…ies (leanprover-community#2028) * refactor(order/bounds): use dot notation, prove more properties Also make parts of `complete_lattice` and `conditionally_complete_lattice` use these lemmas. * Comments * Add a module docstring * Fixes from review, +4 lemmas about images * Fix a typo in the previous commit * Update src/order/bounds.lean * Update src/order/bounds.lean Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make parts of
complete_latticeandconditionally_complete_latticeuse these lemmas.Please review
order/boundsas a new file. It will be easier than analysing the diff.Needs a module docstring.
TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list