chore(data/fintype): move results depending on big_operators #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
Another source of recompiles: |
|
Oof, yes, let's break the chain of imports there. I don't think that "basic facts about lists" should require you to know about ordered rings. Not in this PR, however. |
|
That's not actually an unreasonable import. |
|
@jcommelin, want to mark as ready to merge? |
semorrison
added
the
awaiting-review
jcommelin
approved these changes
Feb 25, 2020
jcommelin
added
ready-to-merge
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…ver-community#2044) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…ver-community#2044) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just rearranging some results. In particular, this PR makes
data.fintypenot depend onalgebra.big_operators, and thus needs to move a few results to a new filedata.fintype.card.I've been wanting to do this for a long time, as I perpetually notice that "easy" bits of the library seem to require recompiling the whole algebraic hierarchy when something in basic tactics changes, and I'm pretty sure the dependency is often via
fintypeimportingalgebra.big_operators, which then imports everything else.I appreciate that reducing compile times is not the greatest principle for deciding how files get divided up ... but compile times are still a huge hassle at the moment.