chore(algebra/group): move is_mul/monoid/group_hom to deprecated/
#2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improve deprecation docstring. TODO: fix compile
Also migrate a few definitions to bundled homs: * use `monoid_hom.map_is_conj` instead of `is_group_hom.is_conj`; * `with_one.lift` and `with_one.map` now take `f` and an explicit argument `h : ∀ x y, f (x * y) = f x * f y` instead of `f` and `[is_mul_hom f]`, and produce a `monoid_hom`. As a side effect, they are now defined for semigroup homomorphisms only.
|
I think it makes sense to separate deprecated code from non-deprecated. If this will be accepted, I'll do the same to |
|
Sounds like a good idea to me! |
semorrison
approved these changes
Feb 28, 2020
semorrison
added
ready-to-merge
urkud
commented
Mar 1, 2020
I wonder if mergify will do its job now.
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…leanprover-community#2056) * Move `is_mul/monoid/group_hom` to `deprecated/` Also improve deprecation docstring. TODO: fix compile * chore(algebra/group): move `is_mul/monoid/group_hom` to `deprecated/` Also migrate a few definitions to bundled homs: * use `monoid_hom.map_is_conj` instead of `is_group_hom.is_conj`; * `with_one.lift` and `with_one.map` now take `f` and an explicit argument `h : ∀ x y, f (x * y) = f x * f y` instead of `f` and `[is_mul_hom f]`, and produce a `monoid_hom`. As a side effect, they are now defined for semigroup homomorphisms only. * Adjust module docstring * Update src/algebra/group/with_one.lean I wonder if mergify will do its job now. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…leanprover-community#2056) * Move `is_mul/monoid/group_hom` to `deprecated/` Also improve deprecation docstring. TODO: fix compile * chore(algebra/group): move `is_mul/monoid/group_hom` to `deprecated/` Also migrate a few definitions to bundled homs: * use `monoid_hom.map_is_conj` instead of `is_group_hom.is_conj`; * `with_one.lift` and `with_one.map` now take `f` and an explicit argument `h : ∀ x y, f (x * y) = f x * f y` instead of `f` and `[is_mul_hom f]`, and produce a `monoid_hom`. As a side effect, they are now defined for semigroup homomorphisms only. * Adjust module docstring * Update src/algebra/group/with_one.lean I wonder if mergify will do its job now. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also migrate a few definitions to bundled homs:
monoid_hom.map_is_conjinstead ofis_group_hom.is_conj;with_one.liftandwith_one.mapnow takefand an explicitargument
h : ∀ x y, f (x * y) = f x * f yinstead offand[is_mul_hom f], and produce amonoid_hom. As a side effect, theyare now defined for semigroup homomorphisms only.
TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list