-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data/finset): new basic material on finsets and fintypes #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgouezel
added
the
awaiting-review
The author would like community review of the PR
label
Feb 29, 2020
jcommelin
reviewed
Feb 29, 2020
jcommelin
reviewed
Mar 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
Co-Authored-By: Johan Commelin <johan@commelin.net>
Co-Authored-By: Johan Commelin <johan@commelin.net>
Co-Authored-By: Johan Commelin <johan@commelin.net>
robertylewis
approved these changes
Mar 2, 2020
robertylewis
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Mar 2, 2020
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…over-community#2068) * feat(data/finset): additional basic material * minor fixes * golfed * Update src/data/finset.lean Co-Authored-By: Johan Commelin <johan@commelin.net> * Update src/data/finset.lean Co-Authored-By: Johan Commelin <johan@commelin.net> * Update src/data/finset.lean Co-Authored-By: Johan Commelin <johan@commelin.net> * golfed Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…over-community#2068) * feat(data/finset): additional basic material * minor fixes * golfed * Update src/data/finset.lean Co-Authored-By: Johan Commelin <johan@commelin.net> * Update src/data/finset.lean Co-Authored-By: Johan Commelin <johan@commelin.net> * Update src/data/finset.lean Co-Authored-By: Johan Commelin <johan@commelin.net> * golfed Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some new material on finsets and fintypes, notably simp lemmas related to inclusions or difference of fintypes. Also
fintype.pi_finset
for the finset of functions defined on a fintype taking values in given finsets.I took this occasion to lint the file
finset.lean
.