Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data/finset): new basic material on finsets and fintypes #2068

Merged
merged 8 commits into from
Mar 2, 2020

Conversation

sgouezel
Copy link
Collaborator

Some new material on finsets and fintypes, notably simp lemmas related to inclusions or difference of fintypes. Also fintype.pi_finset for the finset of functions defined on a fintype taking values in given finsets.

I took this occasion to lint the file finset.lean.

@sgouezel sgouezel added the awaiting-review The author would like community review of the PR label Feb 29, 2020
src/data/finset.lean Outdated Show resolved Hide resolved
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

src/data/finset.lean Outdated Show resolved Hide resolved
src/data/finset.lean Outdated Show resolved Hide resolved
src/data/finset.lean Outdated Show resolved Hide resolved
src/data/fintype.lean Outdated Show resolved Hide resolved
sgouezel and others added 4 commits March 2, 2020 08:39
Co-Authored-By: Johan Commelin <johan@commelin.net>
Co-Authored-By: Johan Commelin <johan@commelin.net>
Co-Authored-By: Johan Commelin <johan@commelin.net>
@robertylewis robertylewis added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 2, 2020
@mergify mergify bot merged commit 8919541 into leanprover-community:master Mar 2, 2020
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…over-community#2068)

* feat(data/finset): additional basic material

* minor fixes

* golfed

* Update src/data/finset.lean

Co-Authored-By: Johan Commelin <johan@commelin.net>

* Update src/data/finset.lean

Co-Authored-By: Johan Commelin <johan@commelin.net>

* Update src/data/finset.lean

Co-Authored-By: Johan Commelin <johan@commelin.net>

* golfed

Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
…over-community#2068)

* feat(data/finset): additional basic material

* minor fixes

* golfed

* Update src/data/finset.lean

Co-Authored-By: Johan Commelin <johan@commelin.net>

* Update src/data/finset.lean

Co-Authored-By: Johan Commelin <johan@commelin.net>

* Update src/data/finset.lean

Co-Authored-By: Johan Commelin <johan@commelin.net>

* golfed

Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@sgouezel sgouezel deleted the more_finset branch May 26, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants