Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(algebra): monoidal category of R-modules #2125

Merged
merged 11 commits into from Mar 14, 2020
Merged

feat(algebra): monoidal category of R-modules #2125

merged 11 commits into from Mar 14, 2020

Conversation

semorrison
Copy link
Collaborator

This was mostly already done due to work by @kckennylau; this PR is just putting together the "collectible" monoidal_category (Module R) instance.

@jcommelin jcommelin added the WIP Work in progress label Mar 13, 2020
@semorrison semorrison added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Mar 14, 2020
@jcommelin jcommelin added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 14, 2020
mergify bot and others added 2 commits March 14, 2020 06:06
@mergify mergify bot merged commit 81d3ebf into master Mar 14, 2020
@mergify mergify bot deleted the monoidal_Module branch March 14, 2020 08:03
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
)

* feat(algebra): monoidal category of R-modules

* docstrings

* minor

* tweaks

* fix import

* fixes

* reduce use of @

* broken

* fixes

* Update src/algebra/category/Module/basic.lean

Co-Authored-By: Bryan Gin-ge Chen <bryangingechen@gmail.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
)

* feat(algebra): monoidal category of R-modules

* docstrings

* minor

* tweaks

* fix import

* fixes

* reduce use of @

* broken

* fixes

* Update src/algebra/category/Module/basic.lean

Co-Authored-By: Bryan Gin-ge Chen <bryangingechen@gmail.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants