chore(category_theory): remove functor.of #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
approved these changes
Mar 11, 2020
jcommelin
added
the
ready-to-merge
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
* chore(category_theory): remove functor.of * fix Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
* chore(category_theory): remove functor.of * fix Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
functor.of, which was just a shorthand forfunctor.const punit. It wasn't used much, and I think was just cruft.Also, I'll at some point PR some work on
functorial, a typeclass saying that a fixed function-on-objects is functorial, which seems to be really helpful when talking about lax monoidal functors, and enriched categories, etc. (I still would like to be able to do homological algebra properly. :-)Once we have
functorial, it will be natural to havefunctor.ofbe the construction that takes the function-on-objects and lifts it to a bundledFunctor. So I'm getting rid of this one first.