chore(order/liminf_limsup): lint and cleanup the file #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
reviewed
Mar 15, 2020
src/order/filter/basic.lean
Outdated
| lemma eventually.congr {f : filter α} {β : Type*} {u v : α → β} {p : β → Prop} | ||
| (h : ∀ᶠ a in f, u a = v a) (h' : ∀ᶠ a in f, p (u a)) : | ||
| ∀ᶠ a in f, p (v a) := | ||
| eventually.mp h' (eventually.mp h (eventually_of_forall f (by simp {contextual := tt}))) |
There was a problem hiding this comment.
I'd use eventually.mono instead of eventually.mp h (eventually_of_forall f _)), same below.
There was a problem hiding this comment.
Done here. I have not understood what you mean by "same below".
robertylewis
approved these changes
Mar 16, 2020
robertylewis
added
the
ready-to-merge
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…munity#2162) * chore(order/liminf_limsup): lint and cleanup the file, add some statements * use eventually_mono Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…munity#2162) * chore(order/liminf_limsup): lint and cleanup the file, add some statements * use eventually_mono Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed some additional statements on liminfs and limsups. I have taken the occasion to clean up the file a little bit.