feat(data/int/gcd) extended gcd to integers #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gml16
changed the title
jcommelin
reviewed
Jul 25, 2018
data/int/basic.lean
Outdated
| @@ -423,7 +423,7 @@ theorem mod_eq_zero_of_dvd : ∀ {a b : ℤ}, a ∣ b → b % a = 0 | |||
| theorem dvd_iff_mod_eq_zero (a b : ℤ) : a ∣ b ↔ b % a = 0 := | |||
| ⟨mod_eq_zero_of_dvd, dvd_of_mod_eq_zero⟩ | |||
|
|
|||
| theorem nat_abs_dvd {a b : ℤ} : (a.nat_abs : ℤ) ∣ b ↔ a ∣ b := | |||
| theorem nat_abs_dvd {a b : ℤ} : (a.nat_abs : ℤ) ∣ b ↔ a ∣ b := | |||
There was a problem hiding this comment.
You added a space at the end of this line.
There was a problem hiding this comment.
Thanks for letting me know, the extra spaces are now removed.
|
I don't think this is the way we want to go. The way to go is to introduce a GCD (semi-)domain. |
|
@gml16 do you want to work on GCD (semi-) domains? |
|
Sure if it's useful feel free to pull the content :) |
johoelzl
pushed a commit
to johoelzl/mathlib
that referenced
this pull request
Aug 31, 2018
Resurrected by @johoelzl. The original commit was not available anymore.
johoelzl
pushed a commit
that referenced
this pull request
Aug 31, 2018
Resurrected by @johoelzl. The original commit was not available anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO CONTRIBUTORS:
Make sure you have:
For reviewers: code review check list