feat(ring_theory/algebra) : generalize rat.algebra_rat to division_ring
#2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ring` Other changes: * add lemmas about field inverse to `algebra/semiconj` and `algebra/commute`; * drop `rat.cast`, define `instance : has_coe` right away to avoid accidental use of `rat.cast` in theorems; * define `rat.cast_hom` instead of `is_ring_hom rat.cast`; * generalize some theorems about from `field` to `division_ring`.
jcommelin
approved these changes
Mar 21, 2020
digama0
approved these changes
Mar 22, 2020
|
Looks good to me too. I would have done this originally except that |
digama0
added
ready-to-merge
cipher1024
pushed a commit
that referenced
this pull request
Apr 20, 2020
…_ring` (#2208) Other changes: * add lemmas about field inverse to `algebra/semiconj` and `algebra/commute`; * drop `rat.cast`, define `instance : has_coe` right away to avoid accidental use of `rat.cast` in theorems; * define `rat.cast_hom` instead of `is_ring_hom rat.cast`; * generalize some theorems about from `field` to `division_ring`. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…_ring` (leanprover-community#2208) Other changes: * add lemmas about field inverse to `algebra/semiconj` and `algebra/commute`; * drop `rat.cast`, define `instance : has_coe` right away to avoid accidental use of `rat.cast` in theorems; * define `rat.cast_hom` instead of `is_ring_hom rat.cast`; * generalize some theorems about from `field` to `division_ring`. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…_ring` (leanprover-community#2208) Other changes: * add lemmas about field inverse to `algebra/semiconj` and `algebra/commute`; * drop `rat.cast`, define `instance : has_coe` right away to avoid accidental use of `rat.cast` in theorems; * define `rat.cast_hom` instead of `is_ring_hom rat.cast`; * generalize some theorems about from `field` to `division_ring`. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other changes:
add lemmas about field inverse to
algebra/semiconjandalgebra/commute;drop
rat.cast, defineinstance : has_coeright away to avoidaccidental use of
rat.castin theorems;define
rat.cast_hominstead ofis_ring_hom rat.cast;generalize some theorems about from
fieldtodivision_ring.