Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(algebra/module): f : E →+ F is ℚ-linear #2215

Merged
merged 3 commits into from Mar 23, 2020
Merged

feat(algebra/module): f : E →+ F is ℚ-linear #2215

merged 3 commits into from Mar 23, 2020

Conversation

urkud
Copy link
Member

@urkud urkud commented Mar 22, 2020

Also cleanup similar lemmas about ℕ and ℤ.

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@urkud
feat(algebra/module): f : E →+ F is ℚ-linear
2d92085 
Also cleanup similar lemmas about `ℕ` and `ℤ`.
urkud
urkud commented Mar 22, 2020
View reviewed changes
src/algebra/module.lean Outdated Show resolved Hide resolved
@urkud urkud added the awaiting-review The author would like community review of the PR label Mar 22, 2020
semorrison
semorrison approved these changes Mar 22, 2020
View reviewed changes
Copy link
Collaborator

@semorrison semorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, and a useful addition!

@semorrison semorrison added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 22, 2020
@mergify mergify bot merged commit 6aa5572 into master Mar 23, 2020
@urkud urkud deleted the rat-linear branch March 25, 2020 01:30
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
@urkud @mergify @anrddh
feat(algebra/module): f : E →+ F is ℚ-linear (leanprover-communit…
a9cd562 
…y#2215)

* feat(algebra/module): `f : E →+ F` is `ℚ`-linear

Also cleanup similar lemmas about `ℕ` and `ℤ`.

* Fix a typo

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
@urkud @mergify @anrddh
feat(algebra/module): f : E →+ F is ℚ-linear (leanprover-communit…
3ce44e6 
…y#2215)

* feat(algebra/module): `f : E →+ F` is `ℚ`-linear

Also cleanup similar lemmas about `ℕ` and `ℤ`.

* Fix a typo

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @semorrison