feat(algebra/big_operators): missing lemmas #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
reviewed
Mar 27, 2020
|
|
||
| variables [decidable_eq α] [canonically_ordered_comm_semiring β] | ||
|
|
||
| lemma prod_le_prod' {s : finset α} {f g : α → β} (h : ∀ i ∈ s, f i ≤ g i) : |
There was a problem hiding this comment.
to_additive?
Also, isn't there already a prod_le_prod? How is this one different?
There was a problem hiding this comment.
It's a typeclass thing: there is no version yet that works on canonically_ordered_comm_semiring β (a.k.a. nnreal for my purposes). And there is no analogue of this in the additive world, as far as I can tell.
There was a problem hiding this comment.
The other prod_le_prod has a comment
/- this is also true for a ordered commutative multiplicative monoid -/.
Is there actually a common generalisation?
jcommelin
approved these changes
Mar 28, 2020
jcommelin
added
the
ready-to-merge
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three missing bigops lemmas.