Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(topology/bounded_continuous_function): composition of limits when uniform convergence #2260

Merged
merged 8 commits into from
Apr 6, 2020

Conversation

sgouezel
Copy link
Collaborator

@sgouezel sgouezel commented Mar 27, 2020

Old version of the PR:

If Fₙ converges uniformly to a function f which is continuous at x, and uₙ tends to x,
then Fₙ (uₙ) tends to f x

New version:

We formulate the notion of uniform convergence of a sequence of functions taking values in a uniform space, together with variations (locally uniform convergence on a set, and so on). We prove that continuity is preserved by such a limit, and also that if Fₙ converges uniformly to a function f which is continuous at x, and uₙ tends to x, then Fₙ (uₙ) tends to f x. Partial implementations of these notions used to be in bounded_continuous_function.lean, only for metric spaces. I moved them to their own file uniform_space/uniform_convergence.lean, and did a bit of cleanup of their uses.

@sgouezel sgouezel added the awaiting-review The author would like community review of the PR label Mar 30, 2020
@PatrickMassot
Copy link
Member

This file lacks a good module docstring. It also contains stuff that have nothing to do with bounded functions, like the lemma added by this PR. Should it go somewhere else?

I'm also a bit surprised to see all those uniform convergence lemmas stated and proved for metric spaces only. Don't they have version in general uniform spaces that could be applied to derive the metric statements?

@sgouezel
Copy link
Collaborator Author

I proved the lemmas in the versions I needed, but you are right that it would be better to have a more general version on uniform spaces. Let me give it a shot.

@sgouezel sgouezel added WIP Work in progress and removed awaiting-review The author would like community review of the PR labels Mar 30, 2020
@sgouezel
Copy link
Collaborator Author

sgouezel commented Apr 3, 2020

I have now properly defined uniform convergence of a sequence of functions taking values in a uniform space, together with the usual variations (locally uniform convergence, locally uniform convergence on a set, and so on), and proved the main theorems in this setting (most notably that continuity is preserved at the limit).

@sgouezel sgouezel added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Apr 3, 2020
Copy link
Member

@PatrickMassot PatrickMassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

src/analysis/analytic/basic.lean Outdated Show resolved Hide resolved
src/topology/metric_space/basic.lean Outdated Show resolved Hide resolved
src/topology/metric_space/basic.lean Outdated Show resolved Hide resolved
src/topology/uniform_space/uniform_convergence.lean Outdated Show resolved Hide resolved
uniformly by continuous functions. We give various versions, within a set or the whole space, at
a single point or at all points, with locally uniform approximation or uniform approximation. All
the statements are derived from a statement about locally uniform approximation within a set at
a point, called `continuous_within_at_of_locally_uniform_approx_of_continuous_within_at`. -/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a definition for this L assumption?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure. I don't think this will show up often (although I have stated the lemmas in this version because it seems to be the minimal version where it holds, and one never knows if this will be needed some day). I would say let's keep it like that, and if it turns out that people use this version then we can add a name.

@PatrickMassot PatrickMassot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 6, 2020
@mergify mergify bot merged commit ff910dc into master Apr 6, 2020
@mergify mergify bot deleted the tendsto_comp branch April 6, 2020 15:34
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…n uniform convergence (leanprover-community#2260)

* feat(topology/bounded_continuous_function): composition of limits when uniform convergence

* better statement

* uniform space version

* cleanup

* fix linter

* reviewer's comments

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
…n uniform convergence (leanprover-community#2260)

* feat(topology/bounded_continuous_function): composition of limits when uniform convergence

* better statement

* uniform space version

* cleanup

* fix linter

* reviewer's comments

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…n uniform convergence (leanprover-community#2260)

* feat(topology/bounded_continuous_function): composition of limits when uniform convergence

* better statement

* uniform space version

* cleanup

* fix linter

* reviewer's comments

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants