Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(measure_theory/borel): borel is not an instance #2326

Merged
merged 11 commits into from Apr 7, 2020
Merged

refactor(measure_theory/borel): borel is not an instance #2326

merged 11 commits into from Apr 7, 2020

Conversation

urkud
Copy link
Member

@urkud urkud commented Apr 5, 2020 •
edited

Commit Message

Redo Borel spaces in a way similar to closed_order_topology/order_topology.

  • borel is no longer an instance;
  • define typeclass opens_measurable_space for a space with measurable_space and topological_space structures such that all open sets are measurable;
  • define typeclass borel_space for a space with measurable_space and topological_space structures such that measurable_space structure is equal to borel;
  • use dot syntax in more cases;
  • review some proofs that started to fail because of this change.

@urkud urkud added needs-documentation This PR is missing required documentation awaiting-review The author would like community review of the PR labels Apr 5, 2020
@urkud urkud removed the needs-documentation This PR is missing required documentation label Apr 5, 2020
sgouezel
sgouezel reviewed Apr 6, 2020
View reviewed changes
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I only have minor comments.

src/measure_theory/borel_space.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_space.lean Outdated Show resolved Hide resolved
src/measure_theory/integration.lean Outdated Show resolved Hide resolved
src/measure_theory/integration.lean Outdated Show resolved Hide resolved
src/measure_theory/integration.lean Show resolved Hide resolved
@robertylewis robertylewis added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 6, 2020
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 7, 2020
@sgouezel sgouezel added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 7, 2020
@mergify mergify bot merged commit 6f75c57 into master Apr 7, 2020
@mergify mergify bot deleted the borel-space branch April 7, 2020 15:32
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
@urkud @anrddh
refactor(measure_theory/borel): borel is not an instance (leanpro…
d54fe0f 
…ver-community#2326)

Redo Borel spaces in a way similar to `closed_order_topology`/`order_topology`.

* `borel` is no longer an `instance`;
* define typeclass `opens_measurable_space` for a space with `measurable_space` and `topological_space` structures such that all open sets are measurable;
* define typeclass `borel_space` for a space with `measurable_space` and `topological_space` structures such that `measurable_space` structure is equal to `borel`;
* use dot syntax in more cases;
* review some proofs that started to fail because of this change.
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
@urkud @anrddh
refactor(measure_theory/borel): borel is not an instance (leanpro…
e39fa53 
…ver-community#2326)

Redo Borel spaces in a way similar to `closed_order_topology`/`order_topology`.

* `borel` is no longer an `instance`;
* define typeclass `opens_measurable_space` for a space with `measurable_space` and `topological_space` structures such that all open sets are measurable;
* define typeclass `borel_space` for a space with `measurable_space` and `topological_space` structures such that `measurable_space` structure is equal to `borel`;
* use dot syntax in more cases;
* review some proofs that started to fail because of this change.
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
@urkud @cipher1024
refactor(measure_theory/borel): borel is not an instance (leanpro…
a880945 
…ver-community#2326)

Redo Borel spaces in a way similar to `closed_order_topology`/`order_topology`.

* `borel` is no longer an `instance`;
* define typeclass `opens_measurable_space` for a space with `measurable_space` and `topological_space` structures such that all open sets are measurable;
* define typeclass `borel_space` for a space with `measurable_space` and `topological_space` structures such that `measurable_space` structure is equal to `borel`;
* use dot syntax in more cases;
* review some proofs that started to fail because of this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @sgouezel @robertylewis