[Merged by Bors] - refactor(*): use [fact p.prime] for frobenius and perfect_closure #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
added
the
awaiting-review
This was referenced Apr 25, 2020
Closed
|
This is a much smaller change than I expected! LGTM, but I've never really studied this part of the library before. |
|
bors merge |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…anprover-community#2518) This also removes the dependency of `algebra.char_p` on `data.padics.padic_norm`, which was only there to make `nat.prime` a class. I also used this opportunity to rename all alphas and betas to `K` and `L` in the perfect closure file.
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…anprover-community#2518) This also removes the dependency of `algebra.char_p` on `data.padics.padic_norm`, which was only there to make `nat.prime` a class. I also used this opportunity to rename all alphas and betas to `K` and `L` in the perfect closure file.
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…anprover-community#2518) This also removes the dependency of `algebra.char_p` on `data.padics.padic_norm`, which was only there to make `nat.prime` a class. I also used this opportunity to rename all alphas and betas to `K` and `L` in the perfect closure file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the dependency of
algebra.char_pondata.padics.padic_norm, which was only there to makenat.primea class.I also used this opportunity to rename all alphas and betas to
KandLin the perfect closure file.TO CONTRIBUTORS:
Please include a summary of the changes made in this PR above "TO CONTRIBUTORS:", as that text will become the commit message. You are also encouraged to append the following co-authorship template if you'd like to acknowledge suggestions / commits made by other users:
Co-authored-by: name name@example.com
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list
If you're confused by comments on your PR like
bors r+orbors d+, please see our notes on bors for information on our merging workflow.