New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor(data/padics/*): use [fact p.prime] to assume that p is prime #2519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
added
the
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
label
Apr 25, 2020
That was really straightforward 😅 |
jcommelin
changed the title
refactor(data/padics/*): use [fact p.prime] to assume that p is prime
refactor(data/padics/*): use [fact p.prime] to assume that p is prime (blocked by #2518)
Apr 25, 2020
jcommelin
added
awaiting-review
The author would like community review of the PR
and removed
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
labels
Apr 25, 2020
jcommelin
changed the title
refactor(data/padics/*): use [fact p.prime] to assume that p is prime (blocked by #2518)
refactor(data/padics/*): use [fact p.prime] to assume that p is prime
Apr 25, 2020
LGTM. |
bors r+ |
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Apr 25, 2020
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
refactor(data/padics/*): use [fact p.prime] to assume that p is prime
[Merged by Bors] - refactor(data/padics/*): use [fact p.prime] to assume that p is prime
Apr 25, 2020
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO CONTRIBUTORS:
Please include a summary of the changes made in this PR above "TO CONTRIBUTORS:", as that text will become the commit message. You are also encouraged to append the following co-authorship template if you'd like to acknowledge suggestions / commits made by other users:
Co-authored-by: name name@example.com
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list
If you're confused by comments on your PR like
bors r+
orbors d+
, please see our notes on bors for information on our merging workflow.