Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(data/padics/*): use [fact p.prime] to assume that p is prime #2519

Closed
wants to merge 3 commits into from

Conversation

jcommelin
Copy link
Member

TO CONTRIBUTORS:

Please include a summary of the changes made in this PR above "TO CONTRIBUTORS:", as that text will become the commit message. You are also encouraged to append the following co-authorship template if you'd like to acknowledge suggestions / commits made by other users:

Co-authored-by: name name@example.com

Make sure you have:

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

If you're confused by comments on your PR like bors r+ or bors d+, please see our notes on bors for information on our merging workflow.

@jcommelin jcommelin added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 25, 2020
@jcommelin
Copy link
Member Author

That was really straightforward 😅
This depends on #2518 .

@jcommelin jcommelin changed the title refactor(data/padics/*): use [fact p.prime] to assume that p is prime refactor(data/padics/*): use [fact p.prime] to assume that p is prime (blocked by #2518) Apr 25, 2020
@jcommelin jcommelin added awaiting-review The author would like community review of the PR and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Apr 25, 2020
@jcommelin jcommelin changed the title refactor(data/padics/*): use [fact p.prime] to assume that p is prime (blocked by #2518) refactor(data/padics/*): use [fact p.prime] to assume that p is prime Apr 25, 2020
@bryangingechen
Copy link
Collaborator

LGTM.

@ChrisHughes24
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 25, 2020
@bors
Copy link

bors bot commented Apr 25, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(data/padics/*): use [fact p.prime] to assume that p is prime [Merged by Bors] - refactor(data/padics/*): use [fact p.prime] to assume that p is prime Apr 25, 2020
@bors bors bot closed this Apr 25, 2020
@bors bors bot deleted the fact-padics branch April 25, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants