Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(data/set/countable): use dot syntax here and there #2617

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - chore(data/set/countable): use dot syntax here and there #2617

wants to merge 4 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented May 6, 2020

Renamed:

  • exists_surjective_of_countable -> countable.exists_surjective;
  • countable_subset -> countable.mono;
  • countable_image -> countable.image;
  • countable_bUnion -> countable.bUnion;
  • countable_sUnion -> countable.sUnion;
  • countable_union -> countable.union;
  • countable_insert -> countable.insert;
  • countable_finite -> finite.countable;

Add:

  • finset.countable_to_set

@urkud urkud added the awaiting-review The author would like community review of the PR label May 6, 2020
@sgouezel
Copy link
Collaborator

sgouezel commented May 6, 2020

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 6, 2020
@urkud urkud mentioned this pull request May 6, 2020
Closed
bors bot pushed a commit that referenced this pull request May 6, 2020
@urkud
chore(data/set/countable): use dot syntax here and there (#2617)
8f29fcf 
Renamed:

* `exists_surjective_of_countable` -> `countable.exists_surjective`;
* `countable_subset` -> `countable.mono`;
* `countable_image` -> `countable.image`;
* `countable_bUnion` -> `countable.bUnion`;
* `countable_sUnion` -> `countable.sUnion`;
* `countable_union` -> `countable.union`;
* `countable_insert` -> `countable.insert`;
* `countable_finite` -> `finite.countable`;

Add:

* `finset.countable_to_set`
@sgouezel
Copy link
Collaborator

sgouezel commented May 6, 2020

bors r-

@bors
Copy link

bors bot commented May 6, 2020

Canceled.

@sgouezel
Copy link
Collaborator

sgouezel commented May 6, 2020

You can set it to bors r+ back once you have fixed the build.

@sgouezel sgouezel removed the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 6, 2020
@urkud
Copy link
Member Author

urkud commented May 6, 2020

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 6, 2020
bors bot pushed a commit that referenced this pull request May 6, 2020
@urkud
chore(data/set/countable): use dot syntax here and there (#2617)
0c8d2e2 
Renamed:

* `exists_surjective_of_countable` -> `countable.exists_surjective`;
* `countable_subset` -> `countable.mono`;
* `countable_image` -> `countable.image`;
* `countable_bUnion` -> `countable.bUnion`;
* `countable_sUnion` -> `countable.sUnion`;
* `countable_union` -> `countable.union`;
* `countable_insert` -> `countable.insert`;
* `countable_finite` -> `finite.countable`;

Add:

* `finset.countable_to_set`
@bors
Copy link

bors bot commented May 7, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/set/countable): use dot syntax here and there [Merged by Bors] - chore(data/set/countable): use dot syntax here and there May 7, 2020
@bors bors bot closed this May 7, 2020
@bors bors bot deleted the countable-dot branch May 7, 2020 00:42
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
@urkud @anrddh
chore(data/set/countable): use dot syntax here and there (leanprover-…
1701fc0 
…community#2617)

Renamed:

* `exists_surjective_of_countable` -> `countable.exists_surjective`;
* `countable_subset` -> `countable.mono`;
* `countable_image` -> `countable.image`;
* `countable_bUnion` -> `countable.bUnion`;
* `countable_sUnion` -> `countable.sUnion`;
* `countable_union` -> `countable.union`;
* `countable_insert` -> `countable.insert`;
* `countable_finite` -> `finite.countable`;

Add:

* `finset.countable_to_set`
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
@urkud @anrddh
chore(data/set/countable): use dot syntax here and there (leanprover-…
2d0f33a 
…community#2617)

Renamed:

* `exists_surjective_of_countable` -> `countable.exists_surjective`;
* `countable_subset` -> `countable.mono`;
* `countable_image` -> `countable.image`;
* `countable_bUnion` -> `countable.bUnion`;
* `countable_sUnion` -> `countable.sUnion`;
* `countable_union` -> `countable.union`;
* `countable_insert` -> `countable.insert`;
* `countable_finite` -> `finite.countable`;

Add:

* `finset.countable_to_set`
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
@urkud @cipher1024
chore(data/set/countable): use dot syntax here and there (leanprover-…
78c75e6 
…community#2617)

Renamed:

* `exists_surjective_of_countable` -> `countable.exists_surjective`;
* `countable_subset` -> `countable.mono`;
* `countable_image` -> `countable.image`;
* `countable_bUnion` -> `countable.bUnion`;
* `countable_sUnion` -> `countable.sUnion`;
* `countable_union` -> `countable.union`;
* `countable_insert` -> `countable.insert`;
* `countable_finite` -> `finite.countable`;

Add:

* `finset.countable_to_set`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @sgouezel