[Merged by Bors] - chore(logic/embedding,order/order_iso): review #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* swap `inj` with `inj'` to match other bundled homomorphisms; * make some arguments explicit to avoid `embedding.of_surjective _` in the pretty printer output; * make `set_value` computable.
|
Has a few conflicts with #2617. I'll resolve them once it is merged. |
sgouezel
reviewed
May 6, 2020
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
…hlib into embedding
|
Yes, LGTM also, all the changes make perfect sense. |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 9, 2020
* swap `inj` with `inj'` to match other bundled homomorphisms; * make some arguments explicit to avoid `embedding.of_surjective _` in the pretty printer output; * make `set_value` computable.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…2618) * swap `inj` with `inj'` to match other bundled homomorphisms; * make some arguments explicit to avoid `embedding.of_surjective _` in the pretty printer output; * make `set_value` computable.
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…2618) * swap `inj` with `inj'` to match other bundled homomorphisms; * make some arguments explicit to avoid `embedding.of_surjective _` in the pretty printer output; * make `set_value` computable.
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…2618) * swap `inj` with `inj'` to match other bundled homomorphisms; * make some arguments explicit to avoid `embedding.of_surjective _` in the pretty printer output; * make `set_value` computable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
injwithinj'to match other bundled homomorphisms;embedding.of_surjective _in the pretty printer output;
set_valuecomputable.