Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(set): preliminaries for Haar measure #3189

Closed
wants to merge 9 commits into from

Conversation

fpvandoorn
Copy link
Member

@fpvandoorn fpvandoorn commented Jun 26, 2020

comp_sup_eq_sup_comp is renamed comp_sup_eq_sup_comp_of_is_total and there is a new version that doesn't assume that the order is linear.
set.image_injective is renamed function.injective.image_injective (in the same way as the existing function.surjective.preimage_injective). set.image_injective is now an iff.


PR 1/5(?) to put the Haar measure in mathlib. This PR: results about (fin)sets

@fpvandoorn
Copy link
Member Author

some changes:

  • comp_sup_eq_sup_comp is renamed comp_sup_eq_sup_comp_linear and there is a new version that doesn't assume that the order is linear
  • set.image_injective is renamed function.injective.image_injective (in the same way as the existing function.surjective.preimage_injective). set.image_injective is now an iff.
  • Other than that, it's mostly additions

@jcommelin
Copy link
Member

@fpvandoorn please put (at least) the name changes in the top post above the ---, so that they end up in the commit message.

@fpvandoorn
Copy link
Member Author

Good idea! Done.

src/data/finset.lean Outdated Show resolved Hide resolved
src/data/set/basic.lean Outdated Show resolved Hide resolved
@semorrison
Copy link
Collaborator

Otherwise, LGTM.

@bryangingechen
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 27, 2020
bors bot pushed a commit that referenced this pull request Jun 27, 2020
`comp_sup_eq_sup_comp` is renamed `comp_sup_eq_sup_comp_of_is_total` and there is a new version that doesn't assume that the order is linear.
`set.image_injective` is renamed `function.injective.image_injective` (in the same way as the existing `function.surjective.preimage_injective`). `set.image_injective` is now an `iff`.
@bors
Copy link

bors bot commented Jun 27, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(set): preliminaries for Haar measure [Merged by Bors] - feat(set): preliminaries for Haar measure Jun 27, 2020
@bors bors bot closed this Jun 27, 2020
@bors bors bot deleted the haar-2 branch June 27, 2020 06:33
fpvandoorn added a commit that referenced this pull request Jul 5, 2020
bors bot pushed a commit that referenced this pull request Jul 6, 2020
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
`comp_sup_eq_sup_comp` is renamed `comp_sup_eq_sup_comp_of_is_total` and there is a new version that doesn't assume that the order is linear.
`set.image_injective` is renamed `function.injective.image_injective` (in the same way as the existing `function.surjective.preimage_injective`). `set.image_injective` is now an `iff`.
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants